Add windows and macos to CI #91
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codetalker7
reviewed
Jan 21, 2023
.github/workflows/ci.yml
Outdated
| runs-on: ${{ matrix.os }} | ||
| strategy: | ||
| matrix: | ||
| version: ['1.7.2'] |
There was a problem hiding this comment.
@ShouvikGhosh2048 here can you change the version to just ['1']? I think our recent tests are in 1.8.x, and this might be making the tests fail.
There was a problem hiding this comment.
Ubuntu fails on 1
There was a problem hiding this comment.
Is it possible to run the test on version 1.8.x?
There was a problem hiding this comment.
@sourish-cmi Yes, with version being ['1'] the CI will get the latest version of Julia. The most recent test was done in 1.8.5: https://github.com/xKDR/CRRao.jl/actions/runs/3978462222/jobs/6820258360
|
@ShouvikGhosh2048 @codetalker7 - this looks like a old PR - if we have already closed it, shall we close the PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@codetalker7
This PR adds Windows and MacOS to the CI.