Fix #1457: Executable war #1465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- PA nextstep - executable war - Clean deps
- PA tpp engine - executable war - Clean deps
- PA web flow - executable war - Clean deps
- PA web flow client - executable war - Clean deps
Closed
banterCZ
reviewed
Oct 30, 2023
banterCZ
reviewed
Oct 30, 2023
|
Please also remove |
- Clean deps - Move deps management to root
- Clean up
- Update docs
banterCZ
reviewed
Oct 31, 2023
banterCZ
reviewed
Oct 31, 2023
banterCZ
reviewed
Oct 31, 2023
powerauth-webflow-client/pom.xml
Outdated
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-starter-web</artifactId> | ||
| <exclusions> | ||
| <exclusion> |
There was a problem hiding this comment.
Otherwise it wont run, failing for missing deps. I think it need to be here
There was a problem hiding this comment.
I mean exclusion of log4j-to-slf4j.
There was a problem hiding this comment.
@banterCZ I have removed the exclusions of log4j-to-slf4j from other poms as well
There was a problem hiding this comment.
🤔 We should revisit all logging dependencies in another issue.
- Fix version dep - Add exclusion
banterCZ
reviewed
Nov 1, 2023
- More elegant version
- More elegant version
- More elegant version
banterCZ
reviewed
Nov 1, 2023
powerauth-webflow-client/pom.xml
Outdated
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-starter-web</artifactId> | ||
| <exclusions> | ||
| <exclusion> |
There was a problem hiding this comment.
I mean exclusion of log4j-to-slf4j.
- Remove log4j-to-slf4j exclusions from spring-boot-starter
- Remove log4j-to-slf4j exclusions from spring-boot-starter
banterCZ
reviewed
Nov 2, 2023
banterCZ
reviewed
Nov 2, 2023
banterCZ
reviewed
Nov 2, 2023
- Add exclusions of servlet apis
banterCZ
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.