Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Executable war #1457

Closed
banterCZ opened this issue Oct 19, 2023 · 3 comments · Fixed by #1465
Closed

Executable war #1457

banterCZ opened this issue Oct 19, 2023 · 3 comments · Fixed by #1465
Assignees
@jandusil
Labels
dependencies Pull requests that update a dependency file enhancement

Comments

@banterCZ
Copy link
Member

Add embedded tomcat as the provided dependency (to be part of WEB-INF/lib-provided but not lib) and make it possible to run it via java -jar.
@banterCZ banterCZ added enhancement dependencies Pull requests that update a dependency file labels Oct 19, 2023
@jnpsk
Copy link
Collaborator

jnpsk commented Oct 23, 2023

This one runs just fine with the standalone profile on.

  • parent pom has org.apache.tomcat.embed:*:*:*:compile banned

Each component {powerauth-nextstep, powerauth-tpp-engine, powerauth-webflow, powerauth-webflow-client}:

  • java -jar executable iff the standalone profile is active
  • tomcat in scope provided iff the standalone profile is active, excluded from transitive dependencies

@jandusil
Copy link
Contributor

@jnpsk cc @banterCZ We are getting rid of the standalone profile. The issue is still relevant

@jandusil jandusil self-assigned this Oct 24, 2023
@jandusil
Copy link
Contributor

I will take it

jandusil added a commit that referenced this issue Oct 30, 2023
@jandusil
Fix #1457: Executable war
98a90fd 
- PA nextstep - executable war
- Clean deps
jandusil added a commit that referenced this issue Oct 30, 2023
@jandusil
Fix #1457: Executable war
00d5c2a 
- PA tpp engine - executable war
- Clean deps
jandusil added a commit that referenced this issue Oct 30, 2023
@jandusil
Fix #1457: Executable war
a0bcda7 
- PA web flow - executable war
- Clean deps
jandusil added a commit that referenced this issue Oct 30, 2023
@jandusil
Fix #1457: Executable war
717e883 
- PA web flow client - executable war
- Clean deps
@jandusil jandusil linked a pull request Oct 30, 2023 that will close this issue
Fix #1457: Executable war #1465
Merged
jandusil added a commit that referenced this issue Oct 30, 2023
@jandusil
Fix #1457: Executable war
ee39ec2 
- Clean deps
- Move deps management to root
jandusil added a commit that referenced this issue Oct 30, 2023
@jandusil
Fix #1457: Executable war
3206737 
- Clean up
jandusil added a commit that referenced this issue Oct 30, 2023
@jandusil
Fix #1457: Executable war
4ae523a 
- Update docs
jandusil added a commit that referenced this issue Oct 31, 2023
@jandusil
Fix #1457: Executable war
322e8eb 
- Fix version dep
- Add exclusion
jandusil added a commit that referenced this issue Nov 1, 2023
@jandusil
Fix #1457: Executable war
290fa7f 
- More elegant version
jandusil added a commit that referenced this issue Nov 1, 2023
@jandusil
Fix #1457: Executable war
95a4adc 
- More elegant version
jandusil added a commit that referenced this issue Nov 1, 2023
@jandusil
Fix #1457: Executable war
8d3e295 
- More elegant version
jandusil added a commit that referenced this issue Nov 1, 2023
@jandusil
Fix #1457: Executable war
a9cbb89 
- Remove log4j-to-slf4j exclusions from spring-boot-starter
jandusil added a commit that referenced this issue Nov 2, 2023
@jandusil
Fix #1457: Executable war
929f11f 
- Remove log4j-to-slf4j exclusions from spring-boot-starter
jandusil added a commit that referenced this issue Nov 2, 2023
@jandusil
Fix #1457: Executable war
9d8e0b6 
- Add exclusions of servlet apis
jandusil added a commit that referenced this issue Nov 2, 2023
@jandusil
Fix #1457: Executable war (#1465)
7ad6883 
* Fix #1457: Executable war
zcgandcomp pushed a commit that referenced this issue Dec 21, 2023
@jandusil @zcgandcomp
Fix #1457: Executable war (#1465)
19aef7e 
* Fix #1457: Executable war
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jandusil jandusil

Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #1457: Executable war wultra/powerauth-webflow
3 participants
@banterCZ @jnpsk @jandusil