Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #223: Improve User-Agent parsing and add tests #224

Merged
merged 13 commits into from
Dec 11, 2023

Conversation

petrdvorak
Copy link
Member

Please check if the tests should cover any other User-Agent string format provided by our mobile token SDK on iOS and Android.

@zcgandcomp zcgandcomp changed the title Fix #223: Improve User-Agent parsing and add rests Fix #223: Improve User-Agent parsing and add tests Nov 22, 2023
@jandusil jandusil linked an issue Nov 22, 2023 that may be closed by this pull request
@banterCZ banterCZ force-pushed the issues/223-user-agent-tests branch from 37b2fbe to e611db2 Compare December 11, 2023 08:34
Copy link
Member

@romanstrobl romanstrobl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work well.

@petrdvorak petrdvorak merged commit 858e37c into develop Dec 11, 2023
4 checks passed
@petrdvorak petrdvorak deleted the issues/223-user-agent-tests branch December 11, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve User-Agent parsing and add rests
5 participants