Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve User-Agent parsing and add rests #223

Closed
petrdvorak opened this issue Oct 28, 2023 · 0 comments · Fixed by #224
Closed

Improve User-Agent parsing and add rests #223

petrdvorak opened this issue Oct 28, 2023 · 0 comments · Fixed by #224
Assignees
@petrdvorak @jandusil
Labels
enhancement

Comments

@petrdvorak
Copy link
Member

No description provided.

@petrdvorak petrdvorak self-assigned this Oct 28, 2023
petrdvorak added a commit that referenced this issue Oct 28, 2023
@petrdvorak
Fix #223: Improve User-Agent parsing and add rests
f62f8d3
@zcgandcomp zcgandcomp mentioned this issue Nov 6, 2023
Closed
@jandusil jandusil linked a pull request Nov 22, 2023 that will close this issue
Fix #223: Improve User-Agent parsing and add tests #224
Merged
banterCZ pushed a commit that referenced this issue Dec 11, 2023
@petrdvorak @banterCZ
Fix #223: Improve User-Agent parsing and add rests
34cb223
petrdvorak added a commit that referenced this issue Dec 11, 2023
@petrdvorak @banterCZ
Fix #223: Improve User-Agent parsing and add tests (#224)
858e37c 
* Fix #223: Improve User-Agent parsing and add rests

* Reformat code

* Add test data

* Refactor to parametrized test

* Add surefire

* Add failure message

* Multiple prefixes

* Make v1 elements optional

* Parse network, os, osVersion and model from another examples

* Rename constant

* Prefer \\d

* Explicit operator precedence

* Extract sub patterns

---------

Co-authored-by: Lubos Racansky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petrdvorak petrdvorak

@jandusil jandusil

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #223: Improve User-Agent parsing and add tests wultra/lime-java-core
2 participants
@petrdvorak @jandusil