Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): use design system in builder - WF-127 #657

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

madeindjs
Copy link
Collaborator

@madeindjs madeindjs commented Nov 28, 2024

  • Use WdsTextField and WdsFieldWrapper in the builder to respect the design system.
  • Adapt the design on settings fields to make it compliant
before after
image image
image image
image image

@madeindjs madeindjs self-assigned this Nov 28, 2024
@madeindjs madeindjs force-pushed the WF-127 branch 2 times, most recently from 02a1d02 to 0773b41 Compare December 3, 2024 21:57
@madeindjs madeindjs marked this pull request as ready for review December 9, 2024 16:29
@ramedina86
Copy link
Collaborator

Looks great! 🚀

  • What do you think about using this element for the chips i.e. CSS, Default, Pick?
Screenshot 2024-12-10 at 17 02 01 - Why did you remove the data types e.g. `Label : Text`?

@madeindjs
Copy link
Collaborator Author

Ha, great suggestion @ramedina86. Indeed, I noticed that chips components were duplicated in many places, but I didn't see the WdsTabs. I'll implement this component and use it.

@ramedina86
Copy link
Collaborator

Why did you remove the data types e.g. Label : Text?
Any thoughts regarding this

Also do you want me to merge or are you gonna add to this PR?

@madeindjs madeindjs marked this pull request as draft December 13, 2024 08:20
@madeindjs madeindjs marked this pull request as ready for review December 13, 2024 14:37
@madeindjs
Copy link
Collaborator Author

@ramedina86, I implemented the WdsTabs

image

I will continue to work on WDS color, but it can be done in a separate PR. Please don't hesitate to merge if it suits you.

@ramedina86 ramedina86 merged commit c01562a into writer:dev Dec 16, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants