feat(ui): Improve wds builder #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the search field sticky on the top.
In some situation, the dropdown was displayed on the left or on the right.
Some components don't have "general" or "style" section. This makes some gap in the UI.
madeindjs
commented
Dec 17, 2024
Comment on lines
+13
to
+14
| variant="neutral" | ||
| size="smallIcon" |
There was a problem hiding this comment.
@ramedina86 , about the help button, the issue is: The help icon includes the circle (here), thus tertiary variant feels weird
I thought about using question_mark icon instead, but it's still not that pretty
So I decided to stik to neutral and this is the result.
Screencast.From.2024-12-17.13-02-20.mp4
WDYT ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take in account feedbacks after the #657
WdsButtonin builderBuilderSelectWDS focus stateBuilderSelect's dropdown vertical onlyWdsDropdownMenusearch bar