chore(ui): improve hash parsing + setup unit test - WF-72 #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madeindjs
commented
Nov 28, 2024
| const { pageKey, routeVars } = parsedHash; | ||
|
|
||
| let hash = ""; | ||
| if (pageKey) { | ||
| hash += `${encodeURIComponent(pageKey)}`; | ||
| } | ||
|
|
||
| if (routeVars.keys.length > 0) { |
There was a problem hiding this comment.
This was a bug, since we need to use .size
> const map = new Map()
undefined
> map.keys.length
0
> map.set('a','b')
Map(1) { 'a' => 'b' }
> map.keys.length
0
> map.size
1
madeindjs
changed the title
It's possible to use `URLSearchParams` instead of complex Regex. As it'sa very testable part of the code, it was a good opportunity to introduceVitest and cover it.This improvement made me realise that a bug was present, and we didn'tserialize the params when converting back the object to hash (`.key =length` was not called).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible to use
URLSearchParamsinstead of complex Regex. As it's a very testable part of the code, it was a good opportunity to introduce Vitest and cover it.This improvement made me realise that a bug was present, and we didn't serialize the params when converting back the object to hash (
.key = lengthwas not called).