Skip to content

Commit

Permalink
chore(ui): improve hash parsing + test - WF-72
Browse files Browse the repository at this point in the history
It's possible to use `URLSearchParams` instead of complex Regex. As it's
a very testable part of the code, it was a good opportunity to introduce
Vitest and cover it.

This improvement made me realise that a bug was present, and we didn't
serialize the params when converting back the object to hash (`.key =
length` was not called).
  • Loading branch information
madeindjs committed Nov 27, 2024
1 parent ec53f21 commit b17a030
Show file tree
Hide file tree
Showing 4 changed files with 495 additions and 54 deletions.
Loading

0 comments on commit b17a030

Please sign in to comment.