Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): implement new Slider. WF-37 #505

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Conversation

madeindjs
Copy link
Collaborator

@madeindjs madeindjs commented Jul 30, 2024

Implement a brand new Slider component from scratch which respect the new Design System guideline

Screencast.from.2024-08-07.23-37-36.mp4

@madeindjs madeindjs self-assigned this Jul 30, 2024
@madeindjs madeindjs marked this pull request as ready for review August 7, 2024 21:35
@FabienArcellier
Copy link
Collaborator

The interaction is smoother with this version.

I realized that the graphic customization is incomplete.

Pasted image 20240809103041

Is this a problem that can be solved in this PR? Here are suggested fields.

accent apply on bar
apply on cursor
primary text apply on title
popover text apply on popover text
popover apply on background popover

@ramedina86
Copy link
Collaborator

I agree with fields suggested by @FabienArcellier but...

We need to transform the accent, otherwise the ball will have the same color as the bar, which isn't a great look. You can use the colorTransformations, please take a look at CoreSwitchInput for example where the color transformations are used.

@madeindjs
Copy link
Collaborator Author

I found that we already have --softenedAccentColor which does the job

--softenedAccentColor: hsl(
from var(--accentColor) calc(h - 12) calc(s + 0) calc(l + 0.21)
);

And I also added popoverColor & popoverBackgroundColor (commit)

Screencast.from.2024-08-13.20-28-05.mp4

Now we are close to the perfection 😁

@ramedina86 ramedina86 merged commit 68167ad into writer:dev Aug 19, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants