Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Implement range selector. WF-4 #573

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Conversation

madeindjs
Copy link
Collaborator

@madeindjs madeindjs commented Sep 29, 2024

I reused the work from #505 to introduce a new range slider

Screencast.from.2024-09-30.00-25-49.mp4

Technically, I introduced:

  • a BaseInputSliderRange copied from BaseInputRange
  • refactored a bit to reuse the thumb (BaseInputSliderThumb) and the layout (BaseInputSliderLayout)
  • added the new component CoreInputSliderRange and declare it
  • create the new event wf-range-change with the transformer that verify the logic

@madeindjs madeindjs self-assigned this Sep 29, 2024
@madeindjs madeindjs changed the title featu(ui). implement range selector. WF-4 featu(ui): Implement range selector. WF-4 Sep 29, 2024
@madeindjs madeindjs marked this pull request as ready for review September 30, 2024 11:52
@FabienArcellier
Copy link
Collaborator

We don't manage min and max relative to the binding. Is it voluntary ?

image

alternative scenario

  • set the value at the minimum on the component, show the real value in the display
  • hide the value when they are outside the component (not recommanded because the user can't get the cursor)

@FabienArcellier FabienArcellier added the enhancement New feature or request label Oct 2, 2024
@FabienArcellier FabienArcellier changed the title featu(ui): Implement range selector. WF-4 featu(ui): Implement range selector - WF-4 Oct 2, 2024
@madeindjs madeindjs changed the title featu(ui): Implement range selector - WF-4 feat(ui): Implement range selector. WF-4 Oct 3, 2024
@madeindjs
Copy link
Collaborator Author

@FabienArcellier , well seen! I fixed it in f864eed

@ramedina86
Copy link
Collaborator

Just tested on Scalingo, works really well - well done! I know first hand how much work it can be to develop these things from scratch

@ramedina86 ramedina86 merged commit 874d5be into writer:dev Oct 22, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants