-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #3005 Namespace our dependencies to prevent conflicts #3008
Conversation
Update: Whoops never mind. Those got fixed in commits that I hadn't pulled down yet. Doh. |
@hellofromtonya All of them should have been updated in this PR, I can't find any reference left when doing a search in the directory, can you? |
@Tabrisrp Sorry about that. I hadn't pulled down the latest commits. Doh. All good. 👍 |
@Davidacu This one is the last one for Alpha 3. It's ready for QA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Regression tests on Activation/Deactivation, Minification/Combine, Lazyload, Cache, Preload and Optimize CSS Delivery, Find the results attached, 99% pass rate, the failed case is known.
testrail-report-21.pdf - Installed with Woocomerce 4.4, all ok 👍
- Tested with Elementor plugin installed which loads
WP_Background_Process
, all ok 👍 - Tested with other plugins that make use of the imported dependencies such as Mobile detect and Fast velocity minify, all good 👍
- No notices or errors found in debug log.
@Davidacu Hey there, I ran into the same error today when installing with |
@dodgepong If I recall correctly, when running with |
@iCaspar Thanks, that did it! |
Fixes #3005 and closes #2126
Following issue #3003, and to prevent possible conflicts in the future, use Mozart to automatically import and namespace our dependencies.
Also regenerate the
advanced-cache.php
file on update to comply with the new path and name of the mobile detect library.Imported Dependencies