Unneeded Symfony/Yaml dependency? (and bundled dev dependencies)

[pjeby]

I've been running into some problems with a wp-cli command that needs a newer version of Symfony/Yaml than is vendored with this plugin, and this plugin ends up blocking it from being loaded because of autoloader precedence.

However, I can't seem to find where the Yaml component is actually used by anything within the Cloudflare plugin, so the dependency appears redundant. (In addition, the bundled vendor/ directory appears to have been built with development dependencies, meaning the distribution is unnecessarily large and prone to overriding other packages with outdated versions as well.)

Perhaps symfony/yaml can now be removed from composer.json and the vendor tree rebuilt with just the non-development dependencies? Thanks.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[pjeby]

Further activity such as?

[jenkoian]

I think it's only used in a single test (

Cloudflare-WordPress/vendor/symfony/yaml/Tests/ParserTest.php

Line 18 in 52541ea

class ParserTest extends TestCase

) ...please consider at the very least to move into a dev dependency. Order of preference:

• Use https://github.com/10up/action-wordpress-plugin-deploy and include composer.json in .distignore (see Unneeded Symfony/Yaml dependency? (and bundled dev dependencies) #247 (comment))
• Remove YAML dependency (although appreciate may be a pain to rewrite that test without it)
• Update to latest version
• Move to dev dependency
• Use Mozart to scope deps https://github.com/coenjacobs/mozart

This relates to #304 a little but this yaml dep is causing us a few problems which I think can be easily resolved. Thanks!

[jenkoian]

Every time I want to clear the object cache I have to disable this plugin due to this issue...obviously it's not all about me, but any movement on this seemingly small change would be greatly appreciated 🙏 .

If you specify which is your favoured approach I'm more than happy to provide a PR 😇

[jenkoian]

• Use https://github.com/10up/action-wordpress-plugin-deploy and include composer.json in .distignore

I actually don't think this will help because the autoloader won't change which is where the problem lies, so can rule that one out

Another option though is to use https://github.com/coenjacobs/mozart this is used by some major plugins already,

[jacobbednarz]

if i understand the issue correctly here, i think this has been fixed since 4.1.0. feel free to let me know if it isn't addressed for you and we can revisit.

[pjeby]

While 4.10 removed the other bundled dev dependencies, symfony/yaml is still listed in require rather than require-dev, still vendored by the plugin, and still autoloaded by it. So the original problem still exists.

[jacobbednarz]

thanks for confirming! do you want to take a pass at addressing this?

[pjeby]

I took a shot at it in #374.