-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bio.tools EDAM #169
base: master
Are you sure you want to change the base?
bio.tools EDAM #169
Conversation
Oh very cool @lecorguille @sneumann @fgiacomoni !!!! ❤️ |
c8a5514
to
c6b57ad
Compare
It fails but it's the classic IPO tool long jobs. FYI here is the current state-of-art of the workflow4metabolomics bio.tools card : https://bio.tools/workflow4metabolomics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here are a few recommendations regarding EDAM annotation from you friendly neighborhood EDAM expert ;)
<edam_topics> | ||
<edam_topic>topic_2259</edam_topic> <!-- Systems biology --> | ||
<edam_topic>topic_3172</edam_topic> <!-- Metabolomics --> | ||
<edam_topic>topic_3307</edam_topic> <!-- Computational biology --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't include Computational Biology because it is the most generic term. Regarding EDAM annotation, the general rule is that you pick the most specific terms you can, but not their parents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any of the other term are children of Computational Biology
!?
But I don't know if I can pick a more precise term in Computational Biology
?
If not, I can understand that it should be remove because not enough specific
</xml> | ||
<xml name="edam_operations"> | ||
<edam_operations> | ||
<edam_operation>operation_0226</edam_operation> <!-- Annotation --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, leave Enrichment Analysis but remove annotation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enrichment Analysis
Categories from a relevant ontology can be used. The input is typically a set of genes or other biological objects, possibly represented by their identifiers, and the output of the analysis is typically a ranked list of categories, each associated with a statistical metric of over-/under-representation within the studied data.
Annotation
This is a broad concept and is used a placeholder for other, more specific concepts.
Indeed Annotation isn't really specific but so far I don't have anything relevant for metabolomics in this branch. But for me, it's different than discover up or over-/under-metabolomics across samples. Or I misunderstood the "Enrichment Analysis" term :/
<edam_topics> | ||
<edam_topic>topic_2259</edam_topic> <!-- Systems biology --> | ||
<edam_topic>topic_3172</edam_topic> <!-- Metabolomics --> | ||
<edam_topic>topic_3307</edam_topic> <!-- Computational biology --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove (see other comments)
<edam_topic>topic_3307</edam_topic> <!-- Computational biology --> | ||
</edam_topics> | ||
<edam_operations> | ||
<edam_operation>operation_0226</edam_operation> <!-- Annotation --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would replace with http://edamontology.org/operation_3214 (Spectral analysis) and http://edamontology.org/operation_3799 (Quantification)
<edam_topic>topic_2259</edam_topic> <!-- Systems biology --> | ||
<edam_topic>topic_3172</edam_topic> <!-- Metabolomics --> | ||
<edam_topic>topic_0121</edam_topic> <!-- Proteomics --> | ||
<edam_topic>topic_3307</edam_topic> <!-- Computational biology --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
<xml name="edam_topics"> | ||
<edam_topics> | ||
<edam_topic>topic_2259</edam_topic> <!-- Systems biology --> | ||
<edam_topic>topic_3172</edam_topic> <!-- Metabolomics --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
Is this PR still alive? @lecorguille |
It would be nice :) Just a small hint, annotating with the bio.tools is enough, no other EDAM annotation is needed as Galaxy tries to get the EDAM mapping directly from bio.tools. |
+1 for continuing on this @lecorguille @yguitton - happy to contribute if needed! |
Here is a first attempt to annotate the tools.
It take place in the bio.tools hackathon hosted today at Pasteur/Paris
ping @fgiacomoni , @hmenager, @sneumann