Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bio.tools EDAM #169

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

bio.tools EDAM #169

wants to merge 5 commits into from

Conversation

lecorguille
Copy link
Member

@lecorguille lecorguille commented Jan 21, 2020

Here is a first attempt to annotate the tools.
It take place in the bio.tools hackathon hosted today at Pasteur/Paris

ping @fgiacomoni , @hmenager, @sneumann

@bgruening
Copy link
Contributor

Oh very cool @lecorguille @sneumann @fgiacomoni !!!! ❤️

@lecorguille
Copy link
Member Author

It fails but it's the classic IPO tool long jobs.
I can fix that easily at the last moment if you guys are agree with those terms.

FYI here is the current state-of-art of the workflow4metabolomics bio.tools card : https://bio.tools/workflow4metabolomics
Unfortunately, there is a real lack of terms in EDAM to describe correctly the metabolomics world.

Copy link

@hmenager hmenager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here are a few recommendations regarding EDAM annotation from you friendly neighborhood EDAM expert ;)

<edam_topics>
<edam_topic>topic_2259</edam_topic> <!-- Systems biology -->
<edam_topic>topic_3172</edam_topic> <!-- Metabolomics -->
<edam_topic>topic_3307</edam_topic> <!-- Computational biology -->

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't include Computational Biology because it is the most generic term. Regarding EDAM annotation, the general rule is that you pick the most specific terms you can, but not their parents

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any of the other term are children of Computational Biology !?
But I don't know if I can pick a more precise term in Computational Biology ?
If not, I can understand that it should be remove because not enough specific

</xml>
<xml name="edam_operations">
<edam_operations>
<edam_operation>operation_0226</edam_operation> <!-- Annotation -->

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, leave Enrichment Analysis but remove annotation

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enrichment Analysis
Categories from a relevant ontology can be used. The input is typically a set of genes or other biological objects, possibly represented by their identifiers, and the output of the analysis is typically a ranked list of categories, each associated with a statistical metric of over-/under-representation within the studied data.

Annotation
This is a broad concept and is used a placeholder for other, more specific concepts.

Indeed Annotation isn't really specific but so far I don't have anything relevant for metabolomics in this branch. But for me, it's different than discover up or over-/under-metabolomics across samples. Or I misunderstood the "Enrichment Analysis" term :/

<edam_topics>
<edam_topic>topic_2259</edam_topic> <!-- Systems biology -->
<edam_topic>topic_3172</edam_topic> <!-- Metabolomics -->
<edam_topic>topic_3307</edam_topic> <!-- Computational biology -->

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove (see other comments)

<edam_topic>topic_3307</edam_topic> <!-- Computational biology -->
</edam_topics>
<edam_operations>
<edam_operation>operation_0226</edam_operation> <!-- Annotation -->

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would replace with http://edamontology.org/operation_3214 (Spectral analysis) and http://edamontology.org/operation_3799 (Quantification)

<edam_topic>topic_2259</edam_topic> <!-- Systems biology -->
<edam_topic>topic_3172</edam_topic> <!-- Metabolomics -->
<edam_topic>topic_0121</edam_topic> <!-- Proteomics -->
<edam_topic>topic_3307</edam_topic> <!-- Computational biology -->

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

<xml name="edam_topics">
<edam_topics>
<edam_topic>topic_2259</edam_topic> <!-- Systems biology -->
<edam_topic>topic_3172</edam_topic> <!-- Metabolomics -->

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@Lain-inrae
Copy link
Contributor

Is this PR still alive? @lecorguille

@bgruening
Copy link
Contributor

It would be nice :)

Just a small hint, annotating with the bio.tools is enough, no other EDAM annotation is needed as Galaxy tries to get the EDAM mapping directly from bio.tools.

@hechth
Copy link
Contributor

hechth commented Jun 23, 2023

+1 for continuing on this @lecorguille @yguitton - happy to contribute if needed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants