-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Self-hosted user UI #21275
Self-hosted user UI #21275
Conversation
… issue/self-hosted-userlist
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
@@ -724,6 +725,13 @@ | |||
AnalyticsUtils.trackWithSiteDetails(AnalyticsTracker.Stat.OPENED_PEOPLE_MANAGEMENT, site); | |||
} | |||
|
|||
public static void viewSelfHostedUsers(Context context, SiteModel site) { |
Check notice
Code scanning / Android Lint
Nullable/NonNull annotation missing on method parameter Note
@@ -724,6 +725,13 @@ | |||
AnalyticsUtils.trackWithSiteDetails(AnalyticsTracker.Stat.OPENED_PEOPLE_MANAGEMENT, site); | |||
} | |||
|
|||
public static void viewSelfHostedUsers(Context context, SiteModel site) { |
Check notice
Code scanning / Android Lint
Nullable/NonNull annotation missing on method parameter Note
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #21275 +/- ##
==========================================
- Coverage 40.46% 40.24% -0.23%
==========================================
Files 1531 1535 +4
Lines 69831 70232 +401
Branches 11444 11545 +101
==========================================
+ Hits 28259 28262 +3
- Misses 39125 39523 +398
Partials 2447 2447 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Exciting to see this feature begin to take shape. The testing instructions passed for me using a Samsung Galaxy S20 running Android 13.
I left a few suggestions to consider, but I do not consider them blockers. Let me know what you think.
WordPress/src/main/java/org/wordpress/android/ui/mysite/items/listitem/SiteListItemBuilder.kt
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/ui/selfhostedusers/SelfHostedUserComposables.kt
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
In this PR, I've combined #21264 (self-hosted user list) and #21270 (self-hosted user detail). This did make for a larger PR, but it should be easier to review than having separate PRs, plus a lot of the code is Jetpack Compose which can be quite verbose.
To test:
self_hosted_users
in debug settingsSelfHostedUsersScreen
and verify they look fine (note that remote avatar images won't load in the preview)Caveats:
users.mp4