Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upkeep/222: modernize developer experience #228

Merged
merged 14 commits into from
Jul 26, 2024
Merged

upkeep/222: modernize developer experience #228

merged 14 commits into from
Jul 26, 2024

Conversation

Sidsector9
Copy link
Member

@Sidsector9 Sidsector9 commented May 16, 2024

All Submissions:

  • Does your code follow the WooCommerce Sniffs variant of WordPress coding standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Will this change require new documentation or changes to existing documentation?

Changes proposed in this Pull Request:

  • Node is updated to v20.
  • NPM is updated to v10.
  • Node and NPM changes are reflected in the Github actions workflows.
  • Build assets are generated by wordpress/scripts only.
  • Entry point for all assets are moved under src/

Closes #222

Steps to test the changes in this Pull Request:

  1. Pull the branch.
  2. Run nvm use or nvm install depending on the situation.
  3. Verify node and NPM versions by running node -v && npm -v.
  4. rm -rf node_modules/.
  5. npm ci && npm run build.
  6. Test the plugin functionality.
  7. Look for any 404 errors in console.
  8. Look for any errors in the debug.log file.
  9. Test the final ZIP.

Changelog entry

Dev - Update NPM packages and node version to v20 to modernize developer experience.

@jeffpaul jeffpaul added this to the Future Release milestone Jul 3, 2024
@qasumitbagthariya
Copy link
Contributor

Regression / Smoke Test Report ✅

Tested with Archive File created via "php woorelease.phar build repo_URL" (Composer version 2.5.5, npm version 8.19.4, node version 16.20.0)

I tested the following on this branch:

  • Regressing testing
  • Simple product
  • subscription product
  • refund
image image

Status- Working expected with Plugin Archive/Zip file same as fix specific branch.

Testing Environment

  • WordPress: 6.6
  • Theme: Storefront 4.6.0
  • Theme: Twenty Twenty-Four 1.2
  • WooCommerce - 9.1.2
  • PHP: 8.0.30
  • Web Server: Nginx 1.20.2
  • Browser: Chrome
  • OS: macOS Ventura 13.3
  • Git Branch: smoke-testing

Next Step- Ready to Merge 🚀

status update:
cc @ankitguptaindia

@vikrampm1 vikrampm1 modified the milestones: Future Release, 1.6.6 Jul 26, 2024
@vikrampm1 vikrampm1 marked this pull request as ready for review July 26, 2024 16:24
@vikrampm1 vikrampm1 mentioned this pull request Jul 26, 2024
22 tasks
@dkotter dkotter merged commit 3a17821 into trunk Jul 26, 2024
5 checks passed
@dkotter dkotter deleted the upkeep/222 branch July 26, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modernize developer experience (npm, Node, Composer, Grunt, wp/scripts)
6 participants