Merge pull request #228 from woocommerce/upkeep/222

upkeep/222: modernize developer experience
woocommerce · Jul 26, 2024 · 3a17821 · 3a17821
2 parents c3ff046 + 2efdef3
commit 3a17821
Show file tree

Hide file tree

Showing 11 changed files with 8,941 additions and 27,001 deletions.
diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml
@@ -36,7 +36,7 @@ jobs:
           key: node-${{ hashFiles('package-lock.json') }}
 
       - name: Node install
-        run: npm install
+        run: npm ci
 
       - name: Build
         run: npm run build

diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-v16
+v20
diff --git a/README.md b/README.md
@@ -4,6 +4,11 @@ The Payfast extension for WooCommerce enables you to accept payments including S
 
 This is the official WooCommerce extension to receive payments using the South African Payfast payments provider.
 
+## Requirements
+
+- Minimum node version 20.x.
+- Minimum NPM version 10.
+
 ## Dependencies
 
 - Requires at least: 6.4

diff --git a/includes/class-wc-gateway-payfast-blocks-support.php b/includes/class-wc-gateway-payfast-blocks-support.php
@@ -45,7 +45,7 @@ public function is_active() {
 	 * @return array
 	 */
 	public function get_payment_method_script_handles() {
-		$asset_path   = WC_GATEWAY_PAYFAST_PATH . '/build/index.asset.php';
+		$asset_path   = WC_GATEWAY_PAYFAST_PATH . '/build/payment-method.asset.php';
 		$version      = WC_GATEWAY_PAYFAST_VERSION;
 		$dependencies = array();
 		if ( file_exists( $asset_path ) ) {
@@ -59,7 +59,7 @@ public function get_payment_method_script_handles() {
 		}
 		wp_register_script(
 			'wc-payfast-blocks-integration',
-			WC_GATEWAY_PAYFAST_URL . '/build/index.js',
+			WC_GATEWAY_PAYFAST_URL . '/build/payment-method.js',
 			$dependencies,
 			$version,
 			true