This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add back filter blocks frontend scripts #9954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
type: bug
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +67.8 kB (+6%) 🔍 Total Size: 1.17 MB
ℹ️ View Unchanged
|
woocommercebot
requested review from
a team and
albarin
and removed request for
a team
5 tasks
kmanijak
reviewed
Jun 22, 2023
There was a problem hiding this comment.
After pasting the code into code editor, Active Filter and Filter by Stock required a recovery:
But even without the fix they work fine in the frontend, so I believe that's not a blocker.
After recovery they still work on the frontend as expected.
About the translations, I'm not sure if I'm doing something wrong, but I still see "Select Color" in classic theme (Storefront)
and lack of translations in Block theme (TT3) 🤔
|
Thanks for the review @kmanijak!
Ups, sorry, I messed it up in the code when adding the Filter by Stock block to the example. It should be fixed now. I see the Active Filters block is still showing the recovery message, but it looks like that's because we changed a classname that invalidated the previous markup. I guess the way to fix that would be to create a migration, but probably out of the scope of this PR.
Hmm, that's weird. I can't reproduce. Can you go to
I think what's happening is that the block headings don't update if you change the language after inserting them, as they are saved in the markup. But I would say that's expected. |
tjcafferkey
approved these changes
Jun 22, 2023
There was a problem hiding this comment.
Works as expected. I also tested the inner blocks version works as expected with both All Products and on the Product Catalog template.
Thanks for fixing this @Aljullu
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
tarunvijwani
pushed a commit
that referenced
this pull request
Jun 22, 2023
thealexandrelara
pushed a commit
that referenced
this pull request
Jun 22, 2023
* Empty commit for release pull request * Add back filter blocks frontend scripts (#9954) * Update readme to add changelog for 10.2.4 * Update version number to 10.2.4 * Update testing instructions for 10.2.4 --------- Co-authored-by: github-actions <[email protected]> Co-authored-by: Albert Juhé Lluveras <[email protected]> Co-authored-by: Tarun Vijwani <[email protected]>
thealexandrelara
pushed a commit
that referenced
this pull request
Jun 22, 2023
thealexandrelara
added a commit
that referenced
this pull request
Jun 23, 2023
* Empty commit for release pull request * Add back filter blocks frontend scripts (#9954) * Update changelog and bump version to 10.4.4 * Add testing notes for 10.4.4 release * Update testing notes for release 10.4.4 * Replace Automated tests badge with Unit and E2E tests badge * Wait for cart to be removed when emptied (#9829) * Temporarily skip PHP Unit Tests for PHP 8.1 and 8.2 (#9859) * Allow failure of the PHP Unit Tests * Limit the PHP versions to 7.4 and 8.0 to run unit tests * Don't allow failing fast * Add a comment explaining the skipped part * Cancel jobs later * Cancel all the steps in workflow based on the same condition --------- Co-authored-by: github-actions <[email protected]> Co-authored-by: Albert Juhé Lluveras <[email protected]> Co-authored-by: Alexandre Lara <[email protected]> Co-authored-by: Mike Jolley <[email protected]> Co-authored-by: Karol Manijak <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds back the Filter block frontend scripts that were removed in #9251.
You will notice the fix is only applied to the Filter by Attribute, Filter by Price and Filter by Stock blocks. If I'm not wrong, these are the only ones that need it, as the Filter by Rating block was released after the Filter Wrapper was created, so there are no instances of the "old markup" for it.
Fixes #9870.
Fixes #9949.
Testing
User Facing Testing
Test that the old markup of filter blocks still works (#9949):
Test that filter blocks translations are loaded correctly (#9870):
WooCommerce Visibility
Changelog