This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 221
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Empty commit for release pull request * Add back filter blocks frontend scripts (#9954) * Update changelog and bump version to 10.4.4 * Add testing notes for 10.4.4 release * Update testing notes for release 10.4.4 * Replace Automated tests badge with Unit and E2E tests badge * Wait for cart to be removed when emptied (#9829) * Temporarily skip PHP Unit Tests for PHP 8.1 and 8.2 (#9859) * Allow failure of the PHP Unit Tests * Limit the PHP versions to 7.4 and 8.0 to run unit tests * Don't allow failing fast * Add a comment explaining the skipped part * Cancel jobs later * Cancel all the steps in workflow based on the same condition --------- Co-authored-by: github-actions <[email protected]> Co-authored-by: Albert Juhé Lluveras <[email protected]> Co-authored-by: Alexandre Lara <[email protected]> Co-authored-by: Mike Jolley <[email protected]> Co-authored-by: Karol Manijak <[email protected]>
- Loading branch information
6 people
authored
Jun 23, 2023
1 parent
532fb99
commit 633e062
Showing
17 changed files
with
182 additions
and
40 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| /** | ||
| * External dependencies | ||
| */ | ||
| import { renderFrontend } from '@woocommerce/base-utils'; | ||
|
|
||
| /** | ||
| * Internal dependencies | ||
| */ | ||
| import Block from './block'; | ||
| import { parseAttributes } from './utils'; | ||
|
|
||
| const getProps = ( el: HTMLElement ) => { | ||
| return { | ||
| isEditor: false, | ||
| attributes: parseAttributes( el.dataset ), | ||
| }; | ||
| }; | ||
|
|
||
| renderFrontend( { | ||
| selector: '.wp-block-woocommerce-attribute-filter', | ||
| Block, | ||
| getProps, | ||
| } ); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| /** | ||
| * External dependencies | ||
| */ | ||
| import { renderFrontend } from '@woocommerce/base-utils'; | ||
|
|
||
| /** | ||
| * Internal dependencies | ||
| */ | ||
| import Block from './block'; | ||
| import { parseAttributes } from './utils'; | ||
|
|
||
| const getProps = ( el: HTMLElement ) => { | ||
| return { | ||
| attributes: parseAttributes( el.dataset ), | ||
| isEditor: false, | ||
| }; | ||
| }; | ||
|
|
||
| renderFrontend( { | ||
| selector: '.wp-block-woocommerce-price-filter', | ||
| Block, | ||
| getProps, | ||
| } ); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| /** | ||
| * External dependencies | ||
| */ | ||
| import { renderFrontend } from '@woocommerce/base-utils'; | ||
|
|
||
| /** | ||
| * Internal dependencies | ||
| */ | ||
| import Block from './block'; | ||
| import { parseAttributes } from './utils'; | ||
|
|
||
| const getProps = ( el: HTMLElement ) => { | ||
| return { | ||
| attributes: parseAttributes( el.dataset ), | ||
| isEditor: false, | ||
| }; | ||
| }; | ||
|
|
||
| renderFrontend( { | ||
| selector: '.wp-block-woocommerce-stock-filter', | ||
| Block, | ||
| getProps, | ||
| } ); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| # Testing notes and ZIP for release 10.4.4 | ||
|
|
||
| Zip file for testing: [woocommerce-gutenberg-products-block.zip](https://github.com/woocommerce/woocommerce-blocks/files/11840529/woocommerce-gutenberg-products-block.zip) | ||
|
|
||
| ## WooCommerce Core | ||
|
|
||
| ### Add back filter blocks frontend scripts ([9954](https://github.com/woocommerce/woocommerce-blocks/pull/9954)) | ||
|
|
||
| #### Test that the old markup of filter blocks still works | ||
|
|
||
| ```text | ||
| Important: test needs to be conducted using WooCommerce 7.8 | ||
| ``` | ||
|
|
||
| 1. Add a new page, click on three dots on the right top corner and select "Code Editor" | ||
|  | ||
|
|
||
| 2. Paste the following code and exit the code editor | ||
|
|
||
| ```HTML | ||
| <!-- wp:columns --> | ||
| <div class="wp-block-columns"><!-- wp:column {"width":"33.33%"} --> | ||
| <div class="wp-block-column" style="flex-basis:33.33%"><!-- wp:woocommerce/price-filter --> | ||
| <div class="wp-block-woocommerce-price-filter is-loading" data-showinputfields="true" data-showfilterbutton="false" data-heading="Filter by price" data-heading-level="3"><span aria-hidden="true" class="wc-block-product-categories__placeholder"></span></div> | ||
| <!-- /wp:woocommerce/price-filter --> | ||
|
|
||
| <!-- wp:woocommerce/attribute-filter {"attributeId":1,"displayStyle":"dropdown","heading":"Filter by Color"} --> | ||
| <div class="wp-block-woocommerce-attribute-filter is-loading" data-attribute-id="1" data-show-counts="true" data-query-type="or" data-heading="Filter by Color" data-heading-level="3" data-display-style="dropdown"><span aria-hidden="true" class="wc-block-product-attribute-filter__placeholder"></span></div> | ||
| <!-- /wp:woocommerce/attribute-filter --> | ||
|
|
||
| <!-- wp:woocommerce/attribute-filter {"attributeId":2,"heading":"Filter by Size"} --> | ||
| <div class="wp-block-woocommerce-attribute-filter is-loading" data-attribute-id="2" data-show-counts="true" data-query-type="or" data-heading="Filter by Size" data-heading-level="3"><span aria-hidden="true" class="wc-block-product-attribute-filter__placeholder"></span></div> | ||
| <!-- /wp:woocommerce/attribute-filter --> | ||
|
|
||
| <!-- wp:woocommerce/active-filters --> | ||
| <div class="wp-block-woocommerce-active-filters is-loading" data-display-style="list" data-heading="Active filters" data-heading-level="3"><span aria-hidden="true" class="wc-block-active-product-filters__placeholder"></span></div> | ||
| <!-- /wp:woocommerce/active-filters --> | ||
|
|
||
| <!-- wp:woocommerce/stock-filter --> | ||
| <div class="wp-block-woocommerce-stock-filter is-loading" data-show-counts="true" data-heading="Filter by stock status" data-heading-level="3"><span aria-hidden="true" class="wc-block-product-stock-filter__placeholder"></span></div> | ||
| <!-- /wp:woocommerce/stock-filter --></div> | ||
| <!-- /wp:column --> | ||
|
|
||
| <!-- wp:column {"width":"66.66%"} --> | ||
| <div class="wp-block-column" style="flex-basis:66.66%"><!-- wp:woocommerce/all-products {"columns":3,"rows":3,"alignButtons":false,"contentVisibility":{"orderBy":true},"orderby":"date","layoutConfig":[["woocommerce/product-image"],["woocommerce/product-title"],["woocommerce/product-price"],["woocommerce/product-rating"],["woocommerce/product-button"]]} --> | ||
| <div class="wp-block-woocommerce-all-products wc-block-all-products" data-attributes="{"alignButtons":false,"columns":3,"contentVisibility":{"orderBy":true},"isPreview":false,"layoutConfig":[["woocommerce/product-image"],["woocommerce/product-title"],["woocommerce/product-price"],["woocommerce/product-rating"],["woocommerce/product-button"]],"orderby":"date","rows":3}"></div> | ||
| <!-- /wp:woocommerce/all-products --></div> | ||
| <!-- /wp:column --></div> | ||
| <!-- /wp:columns --> | ||
| ``` | ||
|
|
||
| 2. Publish the page. | ||
| 3. Go to the frontend. | ||
| 4. Verify filter blocks are rendered correctly. Interact with them and verify they work properly. | ||
|
|
||
| Before | After | ||
| --- | --- | ||
|  |  | ||
|
|
||
|
|
||
|
|
||
| ##### Test that filter blocks translations are loaded correctly | ||
|
|
||
| ```text | ||
| Important: test needs to be conducted using WooCommerce 7.7 | ||
| ``` | ||
|
|
||
| 1. Change your store language to a locale that has translations (ie: Spanish). | ||
| 2. Add the Filter by Attribute, Filter by Price, Filter by Stock and Filter by Rating blocks to a post or page, alongside the Active Filters and Products (beta) blocks. | ||
| 3. In the frontend, interact with the filter blocks and verify they all work properly. | ||
| 4. Verify translations are loaded correctly. Ie: Filter by Attribute shows "Seleccionar" instead of "Select" in the input field. | ||
|
|
||
| Before | After | ||
| --- | --- | ||
|  |  |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters