Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paid Features Performance card #2646

Closed

Conversation

kt-12
Copy link
Collaborator

@kt-12 kt-12 commented Oct 18, 2024

Changes proposed in this Pull Request:

Closes #2538 .

Replace this with a good description of your changes & reasoning.

Screenshots:

Detailed test instructions:

Additional details:

Changelog entry

@kt-12 kt-12 linked an issue Oct 18, 2024 that may be closed by this pull request
6 tasks
@kt-12 kt-12 changed the base branch from develop to feature/2460-google-ads-value-prop October 18, 2024 07:11
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 64.9%. Comparing base (ac6e716) to head (d56f832).

Files with missing lines Patch % Lines
js/src/dashboard/summary-section/paid-features.js 12.5% 7 Missing ⚠️
...rd/summary-section/paid-campaign-promotion-card.js 0.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                           Coverage Diff                           @@
##             feature/2460-google-ads-value-prop   #2646      +/-   ##
=======================================================================
+ Coverage                                  62.7%   64.9%    +2.2%     
- Complexity                                    0    4596    +4596     
=======================================================================
  Files                                       319     794     +475     
  Lines                                      5074   24343   +19269     
  Branches                                   1231    1226       -5     
=======================================================================
+ Hits                                       3180   15790   +12610     
- Misses                                     1721    8381    +6660     
+ Partials                                    173     172       -1     
Flag Coverage Δ
js-unit-tests 62.7% <11.1%> (-<0.1%) ⬇️
php-unit-tests 65.4% <100.0%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
google-listings-and-ads.php 75.0% <ø> (ø)
src/Product/SyncerHooks.php 90.8% <100.0%> (ø)
...rd/summary-section/paid-campaign-promotion-card.js 0.0% <0.0%> (-9.1%) ⬇️
js/src/dashboard/summary-section/paid-features.js 12.5% <12.5%> (ø)

... and 472 files with indirect coverage changes

@kt-12 kt-12 closed this Oct 22, 2024
@kt-12
Copy link
Collaborator Author

kt-12 commented Oct 22, 2024

Closing in favour of #2650

@eason9487 eason9487 deleted the feature/2538-performance-card branch October 23, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants