-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show Ads value prop in Paid Campaign performance card #2538
Comments
joemcgill
added
the
needs design
The issue requires design input/work from a designer.
label
Aug 16, 2024
joemcgill
changed the title
Show value prop in Paid Campaign performance card [⚠ Needs Design]
Show Ads value prop in Paid Campaign performance card
Aug 16, 2024
joemcgill
removed
the
needs design
The issue requires design input/work from a designer.
label
Oct 1, 2024
As part of this issue, we'll deprecate and remove the |
@joemcgill I've added the IB. Can you kindly take a look please? Left a question about the |
@asvinb I've tried to clarify the part about deprecating the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Part of #2460
In order to better explain why someone should set up their first PMax campaign, we'll update the Paid Campaign card in the dashboard to show a similar value prop as the one shown during onboarding.
Acceptance Criteria
Implementation Brief
js/src/dashboard/summary-section/paid-features.js
which will house thePaidFeatures
component.js/src/setup-mc/setup-stepper/setup-paid-ads/paid-ads-features-section.js
PaidAdsFeaturesSection
andPaidFeatures
.js/src/setup-mc/setup-stepper/setup-paid-ads/paid-ads-features-section.js
js/src/components/paid-ads/add-paid-campaign-button.js
.js/src/component
js/src/dashboard/summary-section/index.js
,PaidFeatures
toSummarySection
ifadsSetupComplete
istrue
useAdsCampaigns
useFreeAdCredit()
while implementing this, see Clarify requirements for displaying Free Ads Credits #2599. Instead of any places where that hook is currently in use should be updated so that the Ads Credit banner is always shown when there are no existing campaigns.Test Coverage
PaidFeatures
to be displayed/hidden.Definition Questions
useFreeAdCredit
hook?The text was updated successfully, but these errors were encountered: