Adding compat subpackage for kube-proxy #30447
Open
+15
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aditvil-Dev <[email protected]>
Signed-off-by: Aditvil-Dev <[email protected]>
developer-guy
approved these changes
Oct 9, 2024
EyeCantCU
requested changes
Oct 9, 2024
Dentrax
reviewed
Oct 9, 2024
| @@ -187,6 +187,19 @@ subpackages: | |||
| mkdir -p ${{targets.subpkgdir}}/usr/bin | |||
| ln -s ${{range.key}}-${{vars.kubernetes-version}} ${{targets.subpkgdir}}/usr/bin/${{range.key}} | |||
| - name: kube-proxy-${{vars.kubernetes-version}}-default-compat | |||
There was a problem hiding this comment.
Is this compat package needs to be versioned?
There was a problem hiding this comment.
Following the norm for what has been done for -default packages
|
logs from kube-proxy-pod: |
|
Looks good, but please update the PR description explaining why the change was made |
EyeCantCU
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kube-proxy deployments assume the binary sits at
/usr/local/bin/kube-proxy (see
https://github.com/kubernetes/kubernetes/blob/a35bca903e24ea3cdbecb743c001b4c8f4db9e9c/cmd/kubeadm/app/phases/addons/proxy/manifests.go#L79). This adds a compat package based off of kube-proxy-default (which installs the binary at /usr/bin/kube-proxy) to add a symlink to /usr/local/bin.
Kube-proxy pod expects the binary at
/usr/local/bin.logs from kube-proxy-pod:
Normal Created 13s (x3 over 27s) kubelet Created container kube-proxy Warning Failed 13s (x3 over 26s) kubelet Error: failed to create containerd task: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: "/usr/local/bin/kube-proxy": stat /usr/local/bin/kube-proxy: no such file or directory: unknown