Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernetes-1.31: Add kube-proxy-default-compat subpackage. #29927

Closed
wants to merge 2 commits into from

Conversation

wlynch
Copy link
Contributor

@wlynch wlynch commented Oct 2, 2024

kube-proxy deployments assume the binary sits at
/usr/local/bin/kube-proxy (see
https://github.com/kubernetes/kubernetes/blob/a35bca903e24ea3cdbecb743c001b4c8f4db9e9c/cmd/kubeadm/app/phases/addons/proxy/manifests.go#L79). This adds a compat package based off of kube-proxy-default (which installs the binary at /usr/bin/kube-proxy) to add a symlink to /usr/local/bin.

Related: https://github.com/chainguard-dev/image-requests/issues/3667

@wlynch
Copy link
Contributor Author

wlynch commented Oct 2, 2024

cc @Aditvil-Dev - saw you were also looking at kube-proxy

@Aditvil-Dev
Copy link
Contributor

Need to bump CVEs.
Also, can you make these changes across all enterprises packages as well.

@wlynch
Copy link
Contributor Author

wlynch commented Oct 2, 2024

yup! i'll get a enterprise PR open after this one

Copy link
Contributor

@Aditvil-Dev Aditvil-Dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aditvil-Dev
Copy link
Contributor

Can you also add that to the kubernetes-${{vars.kubernetes-version}}-default subpackage as well.

kube-proxy deployments assume the binary sits at
/usr/local/bin/kube-proxy (see
https://github.com/kubernetes/kubernetes/blob/a35bca903e24ea3cdbecb743c001b4c8f4db9e9c/cmd/kubeadm/app/phases/addons/proxy/manifests.go#L79).
This adds a compat package based off of kube-proxy-default which
installs the binary at /usr/bin/kube-proxy.
@wlynch
Copy link
Contributor Author

wlynch commented Oct 4, 2024

name: kube-proxy-compat-${{vars.kubernetes-version}}

Done, though kube-proxy-${{vars.kubernetes-version}}-default-compat to match other package naming conventions.

Can you also add that to the kubernetes-${{vars.kubernetes-version}}-default subpackage as well.

I don't think we want to? kubernetes-${{vars.kubernetes-version}}-default configures it's own set of symlinks in /usr/bin. This is specifically for kube-proxy where the common config defaults to /usr/local/bin.

I could maybe see making a kubernetes-${{vars.kubernetes-version}}-default-compat package if there are other components that need something similar. I know kube-apiserver does not, I don't know about the others.

@Aditvil-Dev
Copy link
Contributor

Reopend a new PR: #30447

@Aditvil-Dev Aditvil-Dev reopened this Oct 9, 2024
@Aditvil-Dev Aditvil-Dev closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants