Add labels support to lianad #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edouardparis
force-pushed
the
labels-mvp
branch
5 times, most recently
from
88b61ef
to
f3b30e3
Compare
edouardparis
force-pushed
the
labels-mvp
branch
4 times, most recently
from
a7d0378
to
b622203
Compare
Merged
darosior
reviewed
Aug 21, 2023
There was a problem hiding this comment.
A few comments. I like the KISS approach you took. I implemented a functional test here, although there isn't much state consistency to be testing, feel free to cherry-pick it: darosior@af19dd3.
edouardparis
force-pushed
the
labels-mvp
branch
5 times, most recently
from
205cce5
to
ddb3fc3
Compare
darosior
reviewed
Aug 22, 2023
darosior
reviewed
Aug 22, 2023
edouardparis
force-pushed
the
labels-mvp
branch
2 times, most recently
from
deb7cbf
to
ed45ccc
Compare
edouardparis
force-pushed
the
labels-mvp
branch
from
ed45ccc
to
d772297
Compare
darosior
reviewed
Aug 25, 2023
edouardparis
force-pushed
the
labels-mvp
branch
2 times, most recently
from
155cae1
to
260443a
Compare
darosior
reviewed
Aug 27, 2023
Comment on lines
+183
to
+184
| // After Liana 1.1 we upgraded the schema to add the labels table. | ||
| fn migrate_v2_to_v3(conn: &mut rusqlite::Connection) -> Result<(), SqliteDbError> { |
There was a problem hiding this comment.
I've tested this using the test_migration functional test.
edouardparis
force-pushed
the
labels-mvp
branch
from
260443a
to
204c160
Compare
|
ACK 204c160 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.