Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gui labels #621

Merged
merged 6 commits into from
Oct 19, 2023
Merged

Gui labels #621

merged 6 commits into from
Oct 19, 2023

Conversation

edouardparis
Copy link
Member

@edouardparis edouardparis commented Aug 21, 2023

This PR use the lianad update_labels and get_labels commands.
It also introduce new concepts from talks with Kevin and Antoine:

  • User spending is creating a payment, when he does not add multiple recipients anymore, he is doing multiple payment in one bitcoin transaction.
  • a transaction that have multiple outgoing outputs (multiple payment) is tagged as a 'Batch'.

@edouardparis edouardparis force-pushed the gui-labels-mvp branch 10 times, most recently from caeb06a to c0dd299 Compare August 29, 2023 12:29
@edouardparis edouardparis marked this pull request as ready for review September 19, 2023 18:42
@pythcoiner
Copy link
Collaborator

pythcoiner commented Sep 22, 2023

I've built + run, it seems that adding a label on outgoing tx not confirmed will not save the label.
edit: only from the transaction menu

@pythcoiner
Copy link
Collaborator

pythcoiner commented Sep 22, 2023

I've built + run, it seems that adding a label on outgoing tx not confirmed will not save the label. edit: only from the transaction menu

I dig more into that:

  • the label is well saved but the displayed label in transaction menu is not updated, i need to go to another menu and then come back to transaction menu to update the label.
  • I wonder why we got a payment label and a transaction label? can a payment contain several tx? it's not really clear to me...

image

@edouardparis edouardparis force-pushed the gui-labels-mvp branch 2 times, most recently from ede482a to 0414b89 Compare October 18, 2023 15:19
Copy link
Member Author

@edouardparis edouardparis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-ACK 757b53e

@edouardparis edouardparis merged commit 2fbafd9 into wizardsardine:master Oct 19, 2023
18 checks passed
@edouardparis edouardparis deleted the gui-labels-mvp branch October 19, 2023 09:13
@edouardparis
Copy link
Member Author

Thanks for finding the pending txs bug @pythcoiner
I updated the PR description about the change of payments/batch transactions.
We want to gather more feedback from this state with other features, so I choose to merge it and cut in multiple issues the returned feedback from the team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants