Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge launcher and first installer step #1245

Conversation

edouardparis
Copy link
Member

@edouardparis edouardparis commented Aug 30, 2024

When the gui launches, it checks if there is
a wallet in the network datadirs with bitcoin mainnet in priority, then other networks as fallbacks. If it is the case, it tries to display information about the wallet by reading the settings.json file.
If no wallet was found, then the gui displays the choice to either create a wallet or add it.

20240830_10h55m36s_grim
20240830_10h55m53s_grim

When the gui launches, it checks if there is
a wallet in the network datadirs with bitcoin mainnet in priority.
If it is the case, it tries to display information about
the wallet by reading the settings.json file.
If no wallet was found, then the gui displays the choice
to either create a wallet or add it.
Copy link
Collaborator

@jp1ac4 jp1ac4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK c99df6c.

Tested with both local and remote backends.

@edouardparis edouardparis merged commit e1e5860 into wizardsardine:master Aug 30, 2024
20 of 21 checks passed
@edouardparis edouardparis deleted the refac-launcher-merge-installer-step branch August 30, 2024 10:22
@nondiremanuel nondiremanuel added this to the v7 - Liana milestone Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants