Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review home screen of the installer #1221

Open
nondiremanuel opened this issue Aug 7, 2024 · 1 comment
Open

Review home screen of the installer #1221

nondiremanuel opened this issue Aug 7, 2024 · 1 comment
Labels
Enhancement Improving an existing functionality GUI gui related UX

Comments

@nondiremanuel
Copy link
Collaborator

I'm creating this issue to track the activity to be done to the home screen of the installer. The design is being finalized and will be linked to this issue, but the main idea is to have:

  • Main options (Create / Add / Load) immediately visible at the landing page
  • Network selection as a (secondary) option of this landing page. Bitcoin Network (mainnet) by default. TBD which network to load by default, if the last network I used with at least a wallet in it or always mainnet (I would go with the latter at least at first)
  • Share Xpub option still present
  • List of possible existing wallets to load for the specific network given the following limitations:
    • Still maximum one wallet for the ones that use their "own" BE (local bitcoind, local liana managed bitcoind, electrum)
    • Limit to be defined but more than one is possible for the ones with Liana Connect as BE
  • The different wallets will be distinguished by some labels (e.g. "Liana Connect" vs "Bitcoin Core" vs "Electrum" or something like this) and will have more info if required (e.g. email address for "Liana Connect" wallets)

Below an example of the current draft design:
image

@nondiremanuel nondiremanuel added this to the v8 - Liana milestone Aug 7, 2024
@nondiremanuel nondiremanuel added GUI gui related Enhancement Improving an existing functionality UX labels Aug 7, 2024
@nondiremanuel
Copy link
Collaborator Author

Part of this work was already done in v7 in #1245.

For the remaining part (basically showing the different wallets available on the home screen while also allowing to create / add a new one), contrary to what we were saying, I think we necessarily need to either implement multiple wallet support also for local wallets or modify the installer flow. The reason is that if a user already has a wallet with his own node, if we allow him to go through the creation/addition of a new wallet, as per the current flow he could still select the "own node" option and override the existing wallet. The options that come to my mind are:

  • Implementing multiple support for "local" wallets and then proceeding with this change
  • Checking if a "local" wallet is already present when the user creates a new wallet and selects the "own node" option:
    • If no "local" wallet is present on the specific network -> go on normally
    • If a "local" wallet is present -> show a strong warning that says that the previous wallet is going to be overwritten

The first option is obviously preferable for the long-term view of having multiple wallets anyway, but the technical effort required is still unclear. The second would be a short term, faster solution to allow the user see all the wallets he has considering both local and Liana Connect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improving an existing functionality GUI gui related UX
Projects
Status: To be discussed / defined
Development

No branches or pull requests

1 participant