Vercel migration #57
Merged
Vercel migration #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Merged
tony-sull
commented
Sep 26, 2023
netlify/functions/nightly-build.ts
Outdated
There was a problem hiding this comment.
not a great way to replicate this in Vercel unfortunately, I'll setup a cron-job.org account to handle triggering a build webhook
tony-sull
commented
Sep 26, 2023
src/utils/github.ts
Outdated
| if (typeof import.meta.env.PUBLIC_VITE_GITHUB_TOKEN !== 'string') { | ||
| Accept: "application/vnd.github.v3+json", | ||
| }) | ||
| if (typeof import.meta.env.GITHUB_TOKEN !== "string") { |
There was a problem hiding this comment.
we had a mix of a couple variables here, simplified to a single server-only variable
itsMapleLeaf
approved these changes
Sep 26, 2023
tony-sull
added a commit
that referenced
this pull request
Sep 26, 2023
This reverts commit 554cfdc.
tony-sull
added a commit
that referenced
this pull request
Sep 26, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating the site from Netlify to Vercel
TODO:
mainbuild and deploy in Netlify before mergingmain