Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ViewTransitions #56

Merged
merged 4 commits into from
Dec 12, 2023
Merged

Conversation

kyr0
Copy link
Contributor

@kyr0 kyr0 commented Sep 23, 2023

As asked for by @natemoo-re on Discord, I've updated this site for Astro 3 and added <ViewTransitions /> to this site.

Kindly asking for constructive feedback :)

ps.: I'm wondering about the fonts referenced in styles.css not being available in the public directory. This leads to a difference in font rendering between my local version and astro.new production site. I hope that I didn't miss something here and that this is just due to licensing and solved in the CI/CD deployment process.

@tony-sull
Copy link
Contributor

This is excellent, thanks @kyr0! I'm in the process of migrating the site from Netlify to Vercel but will pick this one up as soon as #57 is done

Our fonts setup is a bit unique, we have a volume license for our brand fonts that are hosted in a separate repo with access restrictions to help us keep an eye on how many page views the fonts are used on monthly. The /fonts path is redirected by the public/_redirects file so we can treat the fonts as if they were in public and avoid extra CORS issues along the way

Copy link

vercel bot commented Dec 12, 2023

@itsMapleLeaf is attempting to deploy a commit to the Astro Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Dec 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
astro-new ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2023 5:30pm

@itsMapleLeaf
Copy link
Contributor

Hey! Sorry this fell by the wayside, we've been busy with a lot of stuff 😎

Since I'm working on getting our sites updated, I'll get this updated and merged in 👍

@itsMapleLeaf itsMapleLeaf merged commit 6c57e4c into withastro:main Dec 12, 2023
3 checks passed
Copy link

netlify bot commented Jul 4, 2024

‼️ Deploy request for astro-new rejected.

Name Link
🔨 Latest commit c6958da

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants