Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: showing/hiding empty conversation list placeholder - WPB-14386 #2192
fix: showing/hiding empty conversation list placeholder - WPB-14386 #2192
Changes from all commits
8a34374
87efd7c
a819cfb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 183 in wire-ios/Wire-iOS/Sources/UserInterface/ConversationList/Container/ConversationListViewController+NavigationBar/ConversationListViewController+NavigationBar.swift
GitHub Actions / Test Results
Variable 'selectedFilterImage' was never mutated; consider changing to 'let' constant
Check warning on line 263 in wire-ios/Wire-iOS/Sources/UserInterface/ConversationList/Container/ConversationListViewController+NavigationBar/ConversationListViewController+NavigationBar.swift
GitHub Actions / Test Results
'contentEdgeInsets' was deprecated in iOS 15.0: This property is ignored when using UIButtonConfiguration
Check warning on line 435 in wire-ios/Wire-iOS/Sources/UserInterface/ConversationList/Container/ConversationListViewController+NavigationBar/ConversationListViewController+NavigationBar.swift
GitHub Actions / Test Results
'shared' is deprecated: Please don't access this property, it will be deleted.
Check warning on line 161 in wire-ios/Wire-iOS/Sources/UserInterface/ConversationList/Container/ViewModel/ConversationListViewControllerViewModel.swift
GitHub Actions / Test Results
'shared()' is deprecated: This shared instance has been deprecated. Don't use it.
Check warning on line 293 in wire-ios/Wire-iOS/Sources/UserInterface/ConversationList/Container/ViewModel/ConversationListViewControllerViewModel.swift
GitHub Actions / Test Results
Main actor-isolated instance method 'userDidChange' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
Check warning on line 328 in wire-ios/Wire-iOS/Sources/UserInterface/ConversationList/Container/ViewModel/ConversationListViewControllerViewModel.swift
GitHub Actions / Test Results
Main actor-isolated instance method 'teamDidChange' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
Check warning on line 304 in wire-ios/Wire-iOS/Sources/UserInterface/ConversationList/ListContent/ConversationListContentController/ConversationListContentController.swift
GitHub Actions / Test Results
Immutable value 'previewProvider' was never used; consider replacing with '_' or removing it