Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: showing/hiding empty conversation list placeholder - WPB-14386 #2192

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 22, 2024

BugWPB-14386 [iOS] Empty screen placeholder hides conversations

This PR was automatically cherry-picked based on the following PR:

Original PR description:


Issue

In some cases the empty screen placeholder doesn't get shown or hidden, see the ticket description.

Testing

on iPhone & iPad:

  • Try to archive and unarchive the only conversation in the conversation list. Previously the empty screen placeholder wasn't added or removed.
  • When the conversation list is empty, start a new conversation using the plus button in the navigation bar.

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@github-actions github-actions bot added cherry-pick echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. labels Nov 22, 2024
@caldrian caldrian changed the title fix: showing/hiding empty conversation list placeholder - WPB-14386 fix: showing/hiding empty conversation list placeholder - WPB-14386 Nov 22, 2024
Copy link
Contributor Author

github-actions bot commented Nov 22, 2024

Test Results

    2 files    288 suites   2m 40s ⏱️
1 782 tests 1 782 ✅ 0 💤 0 ❌
1 790 runs  1 790 ✅ 0 💤 0 ❌

Results for commit a819cfb.

♻️ This comment has been updated with latest results.

@caldrian caldrian added this pull request to the merge queue Nov 25, 2024
Merged via the queue into develop with commit 5cba1e8 Nov 25, 2024
11 of 12 checks passed
@caldrian caldrian deleted the fix/empty-screen-hiding-conversation-list-content-WPB-14386-cherry-pick branch November 25, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants