fix(DuplicationService): postTitle and postName are now correctly suf…

…fixed
williarin · Jul 14, 2022 · 6533c7e · 6533c7e
1 parent 8886776
commit 6533c7e
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 1 deletion.
diff --git a/src/Persistence/DuplicationService.php b/src/Persistence/DuplicationService.php
@@ -51,7 +51,7 @@ public function duplicate(
         $properties = $this->getClassPropertyAttributes($clone, BaseEntity::class, $suffix);
 
         foreach ($properties as $property => $attributes) {
-            $entity->{$property} .= \in_array(Slug::class, $attributes, true)
+            $clone->{$property} .= \in_array(Slug::class, $attributes, true)
                 ? '-' . $this->slugger->slug($suffix)
                     ->lower()
                     ->toString()

diff --git a/test/Test/Manipulation/DuplicationServiceTest.php b/test/Test/Manipulation/DuplicationServiceTest.php
@@ -71,4 +71,32 @@ public function testDuplicateByEntity(): void
         self::assertSame(array_column($originalTerms, 'name'), array_column($newTerms, 'name'));
         self::assertEquals($originalTerms, $newTerms);
     }
+
+    public function testDuplicateWithCustomSuffix(): void
+    {
+        $newEntity = $this->duplicationService->duplicate(
+            23,
+            Product::class,
+            DuplicationService::POST_STATUS_DRAFT,
+            ' Custom Suffix',
+        );
+
+        self::assertNotSame(23, $newEntity->id);
+        self::assertIsNumeric($newEntity->id);
+        self::assertSame($newEntity->postTitle, 'Hoodie with Zipper Custom Suffix');
+        self::assertSame($newEntity->sku, 'woo-hoodie-with-zipper-custom-suffix');
+    }
+
+    public function testDuplicateWithPublishPostStatus(): void
+    {
+        $newEntity = $this->duplicationService->duplicate(
+            23,
+            Product::class,
+            DuplicationService::POST_STATUS_PUBLISH,
+        );
+
+        self::assertNotSame(23, $newEntity->id);
+        self::assertIsNumeric($newEntity->id);
+        self::assertSame($newEntity->postStatus, 'publish');
+    }
 }