test: add some tests to increase coverage

williarin · Jul 14, 2022 · 8886776 · 8886776
1 parent 020d04f
commit 8886776
Show file tree

Hide file tree

Showing 15 changed files with 365 additions and 15 deletions.
diff --git a/README.md b/README.md
@@ -1,5 +1,7 @@
 # WordPress Interop
 
+[![Github Workflow](https://github.com/williarin/wordpress-interop/workflows/Test/badge.svg)](https://github.com/williarin/wordpress-interop/actions)
+
 ## Introduction
 
 This library aims to simplify the interaction with WordPress databases through third-party applications.

diff --git a/src/AbstractManagerRegistry.php b/src/AbstractManagerRegistry.php
@@ -4,8 +4,8 @@
 
 namespace Williarin\WordpressInterop;
 
-use InvalidArgumentException;
 use Williarin\WordpressInterop\Bridge\Repository\RepositoryInterface;
+use Williarin\WordpressInterop\Exception\InvalidArgumentException;
 
 abstract class AbstractManagerRegistry implements ManagerRegistryInterface
 {

diff --git a/src/Exception/EntityNotFoundException.php b/src/Exception/EntityNotFoundException.php
@@ -28,17 +28,19 @@ private function implodeCriteria(array $criteria): string
     {
         return implode(', ', array_filter(array_map(
             function (mixed $value, int|string $field): string {
-                $field = $value instanceof RelationshipCondition
-                    ? sprintf('relationship ID "%s"', $value->getRelationshipIdOrOperand())
-                    : $field;
+                if ($value instanceof RelationshipCondition) {
+                    if (is_int($value->getRelationshipIdOrOperand())) {
+                        $field = sprintf('relationship ID "%s"', $value->getRelationshipIdOrOperand());
+                    } else {
+                        $field = sprintf(
+                            'relationship ID %s',
+                            $this->getOperandAsString($value->getRelationshipIdOrOperand()),
+                        );
+                    }
+                }
 
                 if ($value instanceof Operand) {
-                    $value = sprintf(
-                        '"%s"',
-                        is_array($value->getOperand())
-                            ? $this->implodeCriteria($value->getOperand())
-                            : $value->getOperand(),
-                    );
+                    $value = $this->getOperandAsString($value);
                 } elseif ($value instanceof RelationshipCondition) {
                     $value = sprintf('having a field "%s"', $value->getRelationshipFieldName());
                 } elseif ($value instanceof TermRelationshipCondition) {
@@ -57,4 +59,14 @@ function (mixed $value, int|string $field): string {
             array_keys($criteria),
         )));
     }
+
+    private function getOperandAsString(Operand $operand): string
+    {
+        return sprintf(
+            '%s',
+            is_array($operand->getOperand())
+                ? $this->implodeCriteria($operand->getOperand())
+                : sprintf('"%s"', $operand->getOperand()),
+        );
+    }
 }
diff --git a/test/Fixture/Repository/BarRepository.php b/test/Fixture/Repository/BarRepository.php
@@ -4,16 +4,14 @@
 
 namespace Williarin\WordpressInterop\Test\Fixture\Repository;
 
-use Symfony\Component\Serializer\SerializerInterface;
 use Williarin\WordpressInterop\Bridge\Repository\AbstractEntityRepository;
-use Williarin\WordpressInterop\EntityManagerInterface;
 use Williarin\WordpressInterop\Test\Fixture\Entity\Bar;
 
 final class BarRepository extends AbstractEntityRepository
 {
-    public function __construct(protected EntityManagerInterface $entityManager, SerializerInterface $serializer)
+    public function __construct()
     {
-        parent::__construct($entityManager, $serializer, Bar::class);
+        parent::__construct(Bar::class);
     }
 
     public function getBarTerms(): array

diff --git a/test/Test/Bridge/Repository/OptionRepositoryTest.php b/test/Test/Bridge/Repository/OptionRepositoryTest.php
@@ -6,6 +6,7 @@
 
 use Williarin\WordpressInterop\Bridge\Entity\Option;
 use Williarin\WordpressInterop\Bridge\Repository\RepositoryInterface;
+use Williarin\WordpressInterop\Exception\MethodNotFoundException;
 use Williarin\WordpressInterop\Exception\OptionAlreadyExistsException;
 use Williarin\WordpressInterop\Exception\OptionNotFoundException;
 use Williarin\WordpressInterop\Test\TestCase;
@@ -54,6 +55,16 @@ public function testCallMagicGetterForNonExistentOptionThrowsException(): void
         $this->repository->getSomeNonExistentOption();
     }
 
+    public function testCallMagicGetterForNonExistentMethodThrowsException(): void
+    {
+        $this->expectException(MethodNotFoundException::class);
+        $this->repository->someNonExistentMethod();
+    }
+
+    public function testGetEntityClassName(): void
+    {
+        self::assertSame(Option::class, $this->repository->getEntityClassName());
+    }
 
     public function testCreateNewStringValue(): void
     {

diff --git a/test/Test/Bridge/Repository/PostMetaRepositoryTest.php b/test/Test/Bridge/Repository/PostMetaRepositoryTest.php
@@ -20,6 +20,11 @@ protected function setUp(): void
         $this->repository = $this->manager->getRepository(PostMeta::class);
     }
 
+    public function testGetEntityClassName(): void
+    {
+        self::assertSame(PostMeta::class, $this->repository->getEntityClassName());
+    }
+
     public function testFindReturnsCorrectValue(): void
     {
         self::assertEquals('value3', $this->repository->find(11, 'key1'));

diff --git a/test/Test/Bridge/Repository/PostRepositoryTest.php b/test/Test/Bridge/Repository/PostRepositoryTest.php
@@ -12,6 +12,7 @@
 use Williarin\WordpressInterop\Exception\InvalidEntityException;
 use Williarin\WordpressInterop\Exception\InvalidFieldNameException;
 use Williarin\WordpressInterop\Exception\InvalidOrderByOrientationException;
+use Williarin\WordpressInterop\Exception\MethodNotFoundException;
 use Williarin\WordpressInterop\Test\TestCase;
 
 class PostRepositoryTest extends TestCase
@@ -107,6 +108,12 @@ public function testFindOneByPostStatusOrderByDescUsingMagicCall(): void
         self::assertEquals(10, $post->id);
     }
 
+    public function testMagicCallNonExistentMethod(): void
+    {
+        $this->expectException(MethodNotFoundException::class);
+        $this->repository->nothingLikeThis();
+    }
+
     public function testOrderByFieldValidationWithFindOneByUsingMagicCall(): void
     {
         $this->expectException(InvalidFieldNameException::class);

diff --git a/test/Test/Bridge/Repository/ProductRepositoryTest.php b/test/Test/Bridge/Repository/ProductRepositoryTest.php
@@ -216,6 +216,24 @@ public function testOverrideSelectClauseWithinCriteria(): void
         self::assertEquals([$product1, $product2], $products);
     }
 
+    public function testSelectColumnsWithManualEav(): void
+    {
+        $products = $this->repository->findBy([
+            new SelectColumns(['post_title', select_from_eav('sku')]),
+            'sku' => new Operand('hoodie.*logo|zipper', Operand::OPERATOR_REGEXP),
+        ]);
+
+        $product1 = new Product();
+        $product1->postTitle = 'Hoodie with Logo';
+        $product1->sku = 'woo-hoodie-with-logo';
+
+        $product2 = new Product();
+        $product2->sku = 'woo-hoodie-with-zipper';
+        $product2->postTitle = 'Hoodie with Zipper';
+
+        self::assertEquals([$product1, $product2], $products);
+    }
+
     public function testOperatorInWithEavAttribute(): void
     {
         $products = $this->repository->findBySku(

diff --git a/test/Test/Bridge/Repository/TermRepositoryTest.php b/test/Test/Bridge/Repository/TermRepositoryTest.php
@@ -131,4 +131,43 @@ public function testAddTermsToEntity(): void
         self::assertEquals(['external', 'Hoodies', 'Decor', 'MegaBrand'], array_column($termsProduct, 'name'));
         self::assertEquals([1, 6, 1, 2], array_column($termsProduct, 'count'));
     }
+
+    public function testAddTermsToEntityWithoutTermTaxonomyIdAreIgnored(): void
+    {
+        $hoodieTerms = array_map(
+            static function (Term $term) {
+                unset($term->termTaxonomyId);
+                return $term;
+            },
+            $this->repository->findBy([
+                new PostRelationshipCondition(Product::class, [
+                    'post_status' => new Operand(['publish', 'private'], Operand::OPERATOR_IN),
+                    'sku' => 'super-forces-hoodie',
+                ]),
+                'taxonomy' => new Operand(['product_tag', 'product_type', 'product_visibility'], Operand::OPERATOR_NOT_IN),
+            ]),
+        );
+
+        $product = $this->manager->getRepository(Product::class)
+            ->find(37)
+        ;
+
+        $termsProduct = $this->repository->findBy([
+            new PostRelationshipCondition(Product::class, [
+                'id' => $product->id,
+            ]),
+        ]);
+
+        self::assertEquals(['external', 'Decor'], array_column($termsProduct, 'name'));
+
+        $this->repository->addTermsToEntity($product, $hoodieTerms);
+
+        $termsProduct = $this->repository->findBy([
+            new PostRelationshipCondition(Product::class, [
+                'id' => $product->id,
+            ]),
+        ]);
+
+        self::assertEquals(['external', 'Decor'], array_column($termsProduct, 'name'));
+    }
 }
diff --git a/test/Test/Bridge/Type/GenericDataTest.php b/test/Test/Bridge/Type/GenericDataTest.php
@@ -6,6 +6,7 @@
 
 use Williarin\WordpressInterop\Bridge\Type\GenericData;
 use PHPUnit\Framework\TestCase;
+use Williarin\WordpressInterop\Exception\InvalidArgumentException;
 use Williarin\WordpressInterop\Exception\MethodNotFoundException;
 
 class GenericDataTest extends TestCase
@@ -66,4 +67,20 @@ public function testCallRandomMethod(): void
         $this->expectException(MethodNotFoundException::class);
         $genericData->randomMethod();
     }
+
+    public function testGetInvalidProperty(): void
+    {
+        $genericData = new GenericData();
+        $genericData->data = ['test' => 'this is a test'];
+        $this->expectException(InvalidArgumentException::class);
+        $genericData->invalidProperty;
+    }
+
+    public function testGetInvalidPropertyGetter(): void
+    {
+        $genericData = new GenericData();
+        $genericData->data = ['test' => 'this is a test'];
+        $this->expectException(InvalidArgumentException::class);
+        $genericData->getInvalidMethod();
+    }
 }
diff --git a/test/Test/Criteria/RelationshipCriteriaTest.php b/test/Test/Criteria/RelationshipCriteriaTest.php
@@ -0,0 +1,38 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Williarin\WordpressInterop\Test\Criteria;
+
+use PHPUnit\Framework\TestCase;
+use Williarin\WordpressInterop\Criteria\Operand;
+use Williarin\WordpressInterop\Criteria\RelationshipCondition;
+use Williarin\WordpressInterop\Exception\RelationshipIdDeprecationException;
+
+final class RelationshipCriteriaTest extends TestCase
+{
+    public function testGetRelationshipIdWithIdGiven(): void
+    {
+        $condition = new RelationshipCondition(12, '_thumbnail_id');
+        self::assertSame(12, $condition->getRelationshipId());
+    }
+
+    public function testGetRelationshipIdWithOperandGiven(): void
+    {
+        $condition = new RelationshipCondition(new Operand('sku', Operand::OPERATOR_EQUAL), '_thumbnail_id');
+        $this->expectException(RelationshipIdDeprecationException::class);
+        $condition->getRelationshipId();
+    }
+
+    public function testGetRelationshipIdOrOperandWithIdGiven(): void
+    {
+        $condition = new RelationshipCondition(12, '_thumbnail_id');
+        self::assertSame(12, $condition->getRelationshipIdOrOperand());
+    }
+
+    public function testGetRelationshipIdOrOperandWithOperandGiven(): void
+    {
+        $condition = new RelationshipCondition(new Operand('sku', Operand::OPERATOR_EQUAL), '_thumbnail_id');
+        self::assertInstanceOf(Operand::class, $condition->getRelationshipIdOrOperand());
+    }
+}
diff --git a/test/Test/EntityManagerTest.php b/test/Test/EntityManagerTest.php
@@ -31,4 +31,20 @@ public function testGetRepositoryReturnsDefaultEntityRepository(): void
         self::assertInstanceOf(AbstractEntityRepository::class, $repository);
         self::assertNotInstanceOf(BarRepository::class, $repository);
     }
+
+    public function testAddRepository(): void
+    {
+        $this->manager->addRepository(new BarRepository());
+        self::assertInstanceOf(BarRepository::class, $this->manager->getRepository(Bar::class));
+    }
+
+    public function testGetRepositories(): void
+    {
+        $repositories = $this->manager->getRepositories();
+        self::assertEquals([], $repositories);
+
+        $this->manager->addRepository(new BarRepository());
+        $repositories = $this->manager->getRepositories();
+        self::assertCount(1, $repositories);
+    }
 }