Update RotatedSPOsT with mw_ APIs and timer #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asses the effort to change this. Currently without consumers or tests. Concretize friend class declaration Define testing::getMyVars for SPOSetT
TODO when implementing derived classes
Move SpinorSet to a templated class Refactor FreeOrbital class Base typed aliases on SPOSet<T> on OrbitalSetTraits<T> Add FullRealType in SPOSet and RotatedSPOs Add this in templated meta class Add explicit function instantions for FreeOrbital Add templated class SHOSetT Signed-off-by: Steven Hahn <[email protected]> Add PWRealOrbitalSetT template class Revert test_RotatedSPOs.cpp
Follow existing pattern for SplineC2C allowing for std::complex<T>
Add FullRealType in SPOSet and RotatedSPOs Move generic definition after specialization add implicit implementations Fix some errors initial commit of templated PWOribitSetT that compiles cleanup templateitze PWBasis as well, as is dependancy remove inaccurate comment remove polluted commit
Signed-off-by: Steven Hahn <[email protected]>
Signed-off-by: Steven Hahn <[email protected]>
…ctionT. Signed-off-by: Steven Hahn <[email protected]>
Signed-off-by: Steven Hahn <[email protected]>
Reuse SPOSet types
williamfgc
force-pushed
the
ref-add-SPOSetT
branch
4 times, most recently
from
aebd915 to
a04d5db
Compare
williamfgc
force-pushed
the
ref-add-SPOSetT
branch
2 times, most recently
from
d5f6b9b to
c03543c
Compare
williamfgc
force-pushed
the
ref-add-SPOSetT
branch
from
bd5d50f to
ca0baf4
Compare
williamfgc
force-pushed
the
ref-add-SPOSetT
branch
from
12cfc1f to
90194bc
Compare
williamfgc
force-pushed
the
ref-add-SPOSetT
branch
from
90194bc to
1359f2d
Compare
williamfgc
force-pushed
the
ref-add-SPOSetT
branch
4 times, most recently
from
5613648 to
1c1720c
Compare
williamfgc
force-pushed
the
ref-add-SPOSetT
branch
4 times, most recently
from
3adc50f to
a9c510b
Compare
williamfgc
force-pushed
the
ref-add-SPOSetT
branch
5 times, most recently
from
630c02e to
c3298e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw that you had RotatedSPOsT checked off on your list of finished templated derived classes. Recently, I had two PRs merged that don't seem to have been updated in your branch, specifically QMCPACK#4701 and QMCPACK#4706.
I've gone ahead and added the changes into RotatedSPOsT in case this saves you some work and to make sure these changes aren't overlooked.