Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RotatedSPOsT with mw #38

Open
wants to merge 36 commits into
base: ref-add-SPOSetT
Choose a base branch
from

Conversation

PhilipFackler
Copy link

See #21

williamfgc and others added 30 commits August 25, 2023 11:58
Asses the effort to change this.
Currently without consumers or tests.

Concretize friend class declaration

Define testing::getMyVars for SPOSetT
TODO when implementing derived classes
Move SpinorSet to a templated class

Refactor FreeOrbital class

Base typed aliases on SPOSet<T> on OrbitalSetTraits<T>

Add FullRealType in SPOSet and RotatedSPOs

Add this in templated meta class

Add explicit function instantions for FreeOrbital

Add templated class SHOSetT

Signed-off-by: Steven Hahn <[email protected]>

Add PWRealOrbitalSetT template class

Revert test_RotatedSPOs.cpp
Follow existing pattern for SplineC2C allowing for std::complex<T>
Add FullRealType in SPOSet and RotatedSPOs

Move generic definition after specialization

add implicit implementations

Fix some errors

initial commit of templated PWOribitSetT that compiles

cleanup

templateitze PWBasis as well, as is dependancy

remove inaccurate comment

remove polluted commit
Signed-off-by: Steven Hahn <[email protected]>
Reuse SPOSet types
Asses the effort to change this.
Currently without consumers or tests.

Concretize friend class declaration

Define testing::getMyVars for SPOSetT
Move SpinorSet to a templated class

Refactor FreeOrbital class

Base typed aliases on SPOSet<T> on OrbitalSetTraits<T>

Add FullRealType in SPOSet and RotatedSPOs

Add this in templated meta class

Add explicit function instantions for FreeOrbital

Add templated class SHOSetT

Signed-off-by: Steven Hahn <[email protected]>

Add PWRealOrbitalSetT template class

Revert test_RotatedSPOs.cpp
Follow existing pattern for SplineC2C allowing for std::complex<T>
Add FullRealType in SPOSet and RotatedSPOs

Move generic definition after specialization

add implicit implementations

Fix some errors

initial commit of templated PWOribitSetT that compiles

cleanup

templateitze PWBasis as well, as is dependancy

remove inaccurate comment

remove polluted commit
Add templated class LCAOrbitalSetWithCorrectionT

Signed-off-by: Steven Hahn <[email protected]>
Fix PWOrbitalSet alias types
Fix LCAOrbitalSetWithCorrectionT
Reuse SPOSet types

Signed-off-by: Steven Hahn <[email protected]>
Fix function signature
Change order of definition
Add missing implementation to SPOSetBuilderT

Signed-off-by: Steven Hahn <[email protected]>
@PhilipFackler PhilipFackler changed the base branch from develop to ref-add-SPOSetT October 27, 2023 18:44
@williamfgc williamfgc force-pushed the ref-add-SPOSetT branch 5 times, most recently from 630c02e to c3298e8 Compare November 9, 2023 01:49
@PhilipFackler PhilipFackler force-pushed the update_RotatedSPOsT_with_mw branch from 2955e14 to 6f2a7f1 Compare November 10, 2023 19:05
@PhilipFackler PhilipFackler force-pushed the update_RotatedSPOsT_with_mw branch from 6f2a7f1 to b4f0ded Compare November 10, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants