Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-19335] [COMMUNITY] Include instructions to run quickstarts on Kubernetes #572

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kabir
Copy link
Contributor

@kabir kabir commented May 23, 2024

@kabir kabir force-pushed the WFLY-19335-quickstart-kubernetes-readme branch from 69c88f2 to 8247fe3 Compare June 12, 2024 12:45
@bstansberry
Copy link
Contributor

@kabir @emmartins What does 'community' stability mean in the context of QS?

Stability levels have meaning in the sense that users can explicitly opt in to allow things of a given level without risking choosing things at a lower level. This is enforced via things like the --stability param to standalone/domain.sh and parameters passed to galleon-based provisioning tooling.

And, to be blunt, we want to be able to easily make them unavailable downstream.

How does that work for QS?

@kabir
Copy link
Contributor Author

kabir commented Jun 12, 2024

@bstansberry at the moment, the new content should not be rendered in EAP (via Asciidoc if statements around the includes of the k8s content). We already test on Kubernetes but don't advertise it to the users.

@emmartins
Copy link
Contributor

emmartins commented Jun 13, 2024

@bstansberry what @kabir described is the standard way we ATM disable the rendering of upstream only content, e.g.:

ifndef::ProductRelease,EAPXPRelease[]
include::../shared-doc/build-and-run-the-quickstart-with-kubernetes.adoc[leveloffset=+1]
endif::[]

I guess we could consider to replace those attrs with a stability level, something like:

#only defines all stability levels if not product, otherwise only default 
ifndef::ProductRelease[]
:StabilityExperimental:
:StabilityPreview:
:StabilityCommunity:
endif::[]
:StabilityDefault:

#kubernetes feature is community level, once promoted it should use instead  ifdef::StabilityDefault[]
ifdef::StabilityCommunity[]
include::../shared-doc/build-and-run-the-quickstart-with-kubernetes.adoc[leveloffset=+1]
endif::[]

PS: we would still need those ProductRelease,EAPXPRelease attrs, for instance to switch conditional content from wildfly maven plugin to eap maven plugin

@kabir
Copy link
Contributor Author

kabir commented Oct 14, 2024

@bstansberry @emmartins https://issues.redhat.com/browse/WFLY-19335 was merged for WF 33.

Can we merge this issue?

I've updated it to use the new community process headers. I took the liberty of setting Eduardo as the SME and Brian as the outside perspective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants