[WFLY-18582] Add prometheus endpoint to micrometer extension #551
+122
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darranl
reviewed
May 23, 2024
observability/WFLY-18582_add-prometheus-endpoint-to-micrometer-extension.adoc
Outdated
Show resolved
Hide resolved
jamezp
reviewed
Jul 30, 2024
observability/WFLY-18582_add-prometheus-endpoint-to-micrometer-extension.adoc
Show resolved
Hide resolved
observability/WFLY-18582_add-prometheus-endpoint-to-micrometer-extension.adoc
Outdated
Show resolved
Hide resolved
observability/WFLY-18582_add-prometheus-endpoint-to-micrometer-extension.adoc
Show resolved
Hide resolved
observability/WFLY-18582_add-prometheus-endpoint-to-micrometer-extension.adoc
Show resolved
Hide resolved
jasondlee
force-pushed
the
WFLY-18582
branch
2 times, most recently
from
9430c02
to
b824555
Compare
jamezp
approved these changes
Aug 8, 2024
kabir
reviewed
Aug 27, 2024
observability/WFLY-18582_add-prometheus-endpoint-to-micrometer-extension.adoc
Outdated
Show resolved
Hide resolved
jasondlee
force-pushed
the
WFLY-18582
branch
2 times, most recently
from
0545d2b
to
d4ad021
Compare
kabir
approved these changes
Aug 27, 2024
kabir
requested changes
Aug 27, 2024
observability/WFLY-18582_add-prometheus-endpoint-to-micrometer-extension.adoc
Outdated
Show resolved
Hide resolved
jasondlee
force-pushed
the
WFLY-18582
branch
2 times, most recently
from
b88c561
to
a62b1be
Compare
github-actions
bot
added
the
stability-level/community
github-actions
bot
added
stability-level/community
github-actions
bot
added
stability-level/default
github-actions
bot
added
stability-level/default
jasondlee
force-pushed
the
WFLY-18582
branch
from
da4e03e
to
dd95960
Compare
github-actions
bot
added
stability-level/community
bstansberry
reviewed
Nov 27, 2024
observability/WFLY-18582_add-prometheus-endpoint-to-micrometer-extension.adoc
Outdated
Show resolved
Hide resolved
jasondlee
force-pushed
the
WFLY-18582
branch
from
dd95960
to
c36ef0c
Compare
github-actions
bot
added
stability-level/community
bstansberry
reviewed
Nov 27, 2024
| *** `context`: the context (e.g., `/prometheus`) on which the metrics will be exposed | ||
| *** `security-enabled`: whether to secure the context using the user and roles defined in the application server | ||
| ** If the user would like to use `/metrics`, the WildFly metrics extension must be disabled first to avoid a naming conflict. | ||
| * Micrometer, using its OTLP-based push approach, should continue to work in manage domain mode, but if Prometheus is configured to be used on the host controller, the startup attempt of the HC should fail. |
There was a problem hiding this comment.
This needs clarification.
I believe the situation is that an attempt to add the new resource in a domain mode profile will be rejected, during execution of the resource's add operation. (That would be the correct behavior -- reject the attempt to add an illegal config as soon as it happens, which is when the user tries to add it to the domain profile.)
From there I don't think it's necessary to explain what will happen as a consequence of the add op failing as that is just standard WF behavior that applies to any resource add. If the add op happens during boot, boot fails, otherwise the DC reports the failure to the management client (CLI/HAL) that attempted the add.
I think there should be a requirement about noting this in the text description of relevant add op (i.e. the text in LocalDescriptions.properties)
There was a problem hiding this comment.
@bstansberry Text updated. If you're happy with the update, please resolve this conversation. thx.
bstansberry
reviewed
Nov 27, 2024
observability/WFLY-18582_add-prometheus-endpoint-to-micrometer-extension.adoc
Outdated
Show resolved
Hide resolved
bstansberry
reviewed
Nov 27, 2024
observability/WFLY-18582_add-prometheus-endpoint-to-micrometer-extension.adoc
Outdated
Show resolved
Hide resolved
Add analysis document Update to new AD format
jasondlee
force-pushed
the
WFLY-18582
branch
from
c36ef0c
to
5ea03f6
Compare
github-actions
bot
added
stability-level/community
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/WFLY-18582
Add analysis document
Resolves #590