Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies for when still running on ruby 2.7 #480

Merged
merged 2 commits into from
Apr 14, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# main [(unreleased)](https://github.com/whitesmith/rubycritic/compare/v4.9.0...main)

* [CHANGE] Bump cucumber, minitest, parser, rake, reek, rubocop, and ruby_parser dependencies (by [@faisal][])
* [CHANGE] Fix some typos (by [@jbampton][])
* [FEATURE] Add coverage_path configuration option (by [@exoego][])

Expand Down
6 changes: 1 addition & 5 deletions lib/rubycritic/analysers/coverage.rb
Original file line number Diff line number Diff line change
Expand Up @@ -115,11 +115,7 @@ def results
if Gem.loaded_specs['simplecov'].version >= Gem::Version.new('0.19')
::SimpleCov::Result.from_hash(resultset)
else
array = []
resultset.each do |command_name, data|
array << ::SimpleCov::Result.from_hash(command_name => data)
end
array
resultset.map { |command_name, data| ::SimpleCov::Result.from_hash(command_name => data) }
end
end
end
Expand Down
16 changes: 8 additions & 8 deletions rubycritic.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,11 @@ Gem::Specification.new do |spec|
spec.add_runtime_dependency 'flay', '~> 2.13'
spec.add_runtime_dependency 'flog', '~> 4.7'
spec.add_runtime_dependency 'launchy', '>= 2.5.2'
spec.add_runtime_dependency 'parser', '>= 3.2.2.1'
spec.add_runtime_dependency 'parser', '>= 3.2.2.4'
spec.add_runtime_dependency 'rainbow', '~> 3.1.1'
spec.add_runtime_dependency 'reek', '~> 6.0', '< 7.0'
spec.add_runtime_dependency 'reek', '~> 6.1', '< 7.0' # >= 6.2 requires Ruby 3
nunosilva800 marked this conversation as resolved.
Show resolved Hide resolved
spec.add_runtime_dependency 'rexml'
spec.add_runtime_dependency 'ruby_parser', '~> 3.20'
spec.add_runtime_dependency 'ruby_parser', '~> 3.21'
spec.add_runtime_dependency 'simplecov', '>= 0.22.0'
spec.add_runtime_dependency 'tty-which', '~> 0.5.0'
spec.add_runtime_dependency 'virtus', '~> 2.0'
Expand All @@ -49,16 +49,16 @@ Gem::Specification.new do |spec|
else
spec.add_development_dependency 'byebug', '~> 11.0', '>= 10.0'
end
spec.add_development_dependency 'cucumber', '~> 9.0.2', '!= 9.0.0'
spec.add_development_dependency 'cucumber', '~> 9.2.0', '!= 9.0.0'
spec.add_development_dependency 'diff-lcs', '~> 1.3'
spec.add_development_dependency 'fakefs', '~> 2.5.0'
spec.add_development_dependency 'mdl', '~> 0.13.0', '>= 0.12.0'
spec.add_development_dependency 'minitest', '~> 5.20.0', '>= 5.3.0'
spec.add_development_dependency 'minitest', '~> 5.22.2', '>= 5.3.0'
spec.add_development_dependency 'minitest-around', '~> 0.5.0', '>= 0.4.0'
spec.add_development_dependency 'mocha', '~> 2.1.0'
spec.add_development_dependency 'rake', '~> 13.0.6', '>= 11.0.0'
spec.add_development_dependency 'mocha', '~> 2.2.0'
spec.add_development_dependency 'rake', '~> 13.2.0', '>= 11.0.0'
spec.add_development_dependency 'rexml', '>= 3.2.0'
spec.add_development_dependency 'rubocop', '~> 1.57.1', '>= 1.54.0'
spec.add_development_dependency 'rubocop', '~> 1.59.0', '>= 1.54.0' # >= 1.60 requires Ruby 3
spec.add_development_dependency 'rubocop-minitest'
spec.add_development_dependency 'rubocop-performance'
spec.add_development_dependency 'rubocop-rake'
Expand Down
Loading