-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump dependencies for when still running on ruby 2.7 #480
Bump dependencies for when still running on ruby 2.7 #480
Conversation
1750ae9
to
fb22085
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll comment more fully there, but for purposes of this PR I do think that supporting Ruby 2.7 is starting to hold us back. For example, I believe that updating the minimum Ruby to 3.0 would allow currently us to pull our dependencies up to minitest 5.22.2, rake 13.1.0, and rubocop 1.61.0. |
I started a branch for dropping 2.7 support. Once we know what we're doing with this PR, it should be a quick turn to make a PR out of that branch. |
fb22085
to
49cd616
Compare
49cd616
to
b1f7add
Compare
b1f7add
to
338468f
Compare
…_parser dependencies Also address Lint/UselessAssignment and Style/MapIntoArray warnings that newer versions of rubocop will complain about on newer versions of Ruby.
338468f
to
59b1e1d
Compare
Is it worth integrating the fix from #486 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since Reek 6.2+ requires ruby 3, we can make RubyCritic v4.9.x the last one with ruby 2.7 support.
We can either require a min of ruby v3.0.0 in RubyCritic v4.10, or make it v5.0. Don't really have a strong opinion on this.
Bump cucumber, minitest, parser, rake, reek, rubocop, and ruby_parser dependencies.
This is a pull request to update dependencies, intended for landing as part of an update that we put together for other reasons. I expect to update it from time to time when I notice other relevant dependency updates.
Check list: