Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the “Feature Policy integration” section #322

Merged
merged 3 commits into from
Mar 26, 2021

Conversation

sideshowbarker
Copy link
Contributor

@sideshowbarker sideshowbarker commented Mar 25, 2021

See #321 and #295


Preview | Diff

@annevk
Copy link
Member

annevk commented Mar 25, 2021

Thanks, you'll also need to remove the instance of sync-xhr elsewhere.

@sideshowbarker
Copy link
Contributor Author

Thanks, you'll also need to remove the instance of sync-xhr elsewhere.

That’s in https://github.com/w3c/webappsec-permissions-policy/blob/ab4fa82727f370307117e61d170ca9a2f21dc29b/index.bs#L1126-L1128

So, I’ll raise a PR against the Permissions Policy spec to drop or change that.

But note also, the Permissions Policy has an example with this:

   const new_frame = document.createElement('iframe');
   new_frame.allow = 'sync-xhr';
   // This will be true, as the iframe is allowed to use sync-xhr at whatever URL is
   // mentioned in its src attribute, even though that attribute is not yet set.
   const is_sync_xhr_allowed = new_frame.featurePolicy.allowsFeature('sync-xhr');

https://w3c.github.io/webappsec-permissions-policy/#example-92e8a40f

So, I guess I’ll need replace that example with something else. Suggestion welcome.

@annevk
Copy link
Member

annevk commented Mar 25, 2021

I didn't mean that, sorry, I meant the step in https://xhr.spec.whatwg.org/#dom-xmlhttprequest-send (which is why the build is failing). But if you want to take the other bits on as well, sounds good to me. 😊

A good example of a Permissions Policy would be camera or geolocation.

@sideshowbarker
Copy link
Contributor Author

I didn't mean that, sorry, I meant the step in xhr.spec.whatwg.org/#dom-xmlhttprequest-send (which is why the build is failing).

ah OK — pushed a commit to drop that step

But if you want to take the other bits on as well, sounds good to me. 😊

A good example of a Permissions Policy would be camera or geolocation.

Thanks — I’ll raise a PR against the Permissions Policy spec to change the example/reference there to one of those

@sideshowbarker
Copy link
Contributor Author

For the sync-xhr references in the Permissions Policy spec, I just raised an issue w3c/webappsec-permissions-policy#419

@annevk
Copy link
Member

annevk commented Mar 26, 2021

@sideshowbarker thanks! It seems this needs an update to MDN as well as it currently references XHR for this?

@annevk annevk added the impacts documentation Used by documentation communities, such as MDN, to track changes that impact documentation label Mar 26, 2021
@annevk
Copy link
Member

annevk commented Mar 26, 2021

Ah, that was resolved by mdn/browser-compat-data@bcc150f.

@sideshowbarker
Copy link
Contributor Author

sideshowbarker commented Mar 26, 2021

Ah, that was resolved by mdn/browser-compat-data@bcc150f.

Yeah but actually there are some other changes we can make to mdn/content; I’ll raise a PR there too

@annevk annevk merged commit 9157397 into main Mar 26, 2021
@annevk annevk deleted the sideshowbarker/feature-policy-section-drop branch March 26, 2021 10:32
sideshowbarker added a commit to mdn/content that referenced this pull request Mar 26, 2021
whatwg/xhr#322 removed the “sync-xhr”
policy-controlled feature from XHR spec — so this change adds a
Deprecated header to the “Feature-Policy: sync-xhr”, and removes the
Specifications table (since it’s no longer in the spec).
@sideshowbarker
Copy link
Contributor Author

mdn/content#3529 is the update to the https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Feature-Policy/sync-xhr article

sideshowbarker added a commit to mdn/content that referenced this pull request Mar 26, 2021
whatwg/xhr#322 removed the “sync-xhr”
policy-controlled feature from XHR spec — so this change removes the
Specifications table from the “Feature-Policy: sync-xhr” article.
Elchi3 pushed a commit to mdn/content that referenced this pull request Apr 12, 2021
whatwg/xhr#322 removed the “sync-xhr”
policy-controlled feature from XHR spec — so this change removes the
Specifications table from the “Feature-Policy: sync-xhr” article.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impacts documentation Used by documentation communities, such as MDN, to track changes that impact documentation
Development

Successfully merging this pull request may close these issues.

2 participants