Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop spec table from “Feature-Policy: sync-xhr” article #3529

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

sideshowbarker
Copy link
Collaborator

@sideshowbarker sideshowbarker commented Mar 26, 2021

whatwg/xhr#322 removed the sync-xhr policy-controlled feature from XHR spec — so this change removes the Specifications table from the “Feature-Policy: sync-xhr” article.

@sideshowbarker sideshowbarker requested a review from a team as a code owner March 26, 2021 10:39
@sideshowbarker sideshowbarker requested review from mirunacurtean and removed request for a team March 26, 2021 10:39
@domenic
Copy link
Contributor

domenic commented Mar 26, 2021

I'm not sure deprecated is right here: it's rather experimental, like many other only-one-implementer features.

whatwg/xhr#322 removed the “sync-xhr”
policy-controlled feature from XHR spec — so this change removes the
Specifications table from the “Feature-Policy: sync-xhr” article.
@sideshowbarker sideshowbarker force-pushed the sideshowbarker/feature-policy/sync-xhr-deprecate branch from 4130eb7 to 1f59dba Compare March 26, 2021 22:37
@sideshowbarker sideshowbarker changed the title Mark “Feature-Policy: sync-xhr” deprecated Drop spec table from “Feature-Policy: sync-xhr” article Mar 26, 2021
@sideshowbarker
Copy link
Collaborator Author

I'm not sure deprecated is right here: it's rather experimental, like many other only-one-implementer features.

You’re right. So I’ve reverted the part of the change that added the Deprecated header and that instead has SeeCompatTable — to point readers at the Browser Compatibility table — and instead kept just the part of the change that drops the Specifications table. (And updated the PR description here, and the commit message.)

@sideshowbarker
Copy link
Collaborator Author

@mirunacurtean I think this one is ready for re-review and merging

@Elchi3 Elchi3 merged commit 3275a68 into main Apr 12, 2021
@Elchi3 Elchi3 deleted the sideshowbarker/feature-policy/sync-xhr-deprecate branch April 12, 2021 10:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants