-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export terms referenced from w3c/ServiceWorker#1545 #6325
Open
yutakahirano
wants to merge
1
commit into
whatwg:main
Choose a base branch
from
yutakahirano:yhirano/export-cross-origin-isolation-mode
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+8
−5
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2720,7 +2720,7 @@ a.setAttribute('href', 'https://example.com/'); // change the content attribute | |
<ul class="brief"> | ||
<li><dfn data-x-href="https://tc39.es/ecma262/#active-function-object">active function object</dfn></li> | ||
<li><dfn data-x-href="https://tc39.es/ecma262/#sec-agents">agent</dfn> and | ||
<dfn data-x-href="https://tc39.es/ecma262/#sec-agent-clusters">agent cluster</dfn></li> | ||
<dfn export data-x-href="https://tc39.es/ecma262/#sec-agent-clusters">agent cluster</dfn></li> | ||
<li><dfn data-x-href="https://tc39.es/ecma262/#sec-automatic-semicolon-insertion">automatic semicolon insertion</dfn></li> | ||
<li><dfn data-x-href="https://tc39.es/ecma262/#sec-candidate-executions">candidate execution</dfn></li> | ||
<li>The <dfn data-x-href="https://tc39.es/ecma262/#current-realm">current Realm Record</dfn></li> | ||
|
@@ -78268,9 +78268,12 @@ console.assert(iframeWindow.frameElement === null); | |
<span>cross-origin isolation mode</span>. It is initially "<code | ||
data-x="cross-origin-isolation-none">none</code>".</p> | ||
|
||
<p>A <dfn>cross-origin isolation mode</dfn> is one of three possible values: "<dfn><code | ||
data-x="cross-origin-isolation-none">none</code></dfn>", "<dfn><code | ||
data-x="cross-origin-isolation-logical">logical</code></dfn>", or "<dfn><code | ||
<p>A <dfn export>cross-origin isolation mode</dfn> is one of three possible values: "<dfn | ||
export for="cross-origin isolation mode"><code | ||
data-x="cross-origin-isolation-none">none</code></dfn>", "<dfn export | ||
for="cross-origin isolation mode"><code | ||
data-x="cross-origin-isolation-logical">logical</code></dfn>", or "<dfn export | ||
for="cross-origin isolation mode"><code | ||
data-x="cross-origin-isolation-concrete">concrete</code></dfn>".</p> | ||
|
||
<div class="note"> | ||
|
@@ -87210,7 +87213,7 @@ interface <dfn>BeforeUnloadEvent</dfn> : <span>Event</span> { | |
|
||
<div w-nodev> | ||
|
||
<p>An <span>agent cluster</span> has an associated <dfn | ||
<p>An <span>agent cluster</span> has an associated <dfn export | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This needs |
||
data-x="agent-cluster-cross-origin-isolation">cross-origin isolation mode</dfn>, which is a | ||
<span>cross-origin isolation mode</span>. It is initially "<code | ||
data-x="cross-origin-isolation-none">none</code>".</p> | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If service workers needs to talk about agent clusters it should also reference JavaScript directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still applies.