Export terms referenced from w3c/ServiceWorker#1545 #6325
Conversation
|
w3c/ServiceWorker#1545 has not been approved yet. Probably reviewing it and this change together is good. |
There was a problem hiding this comment.
One quick comment, but I'll let @annevk guide this into merging since it seems he has opinions on w3c/ServiceWorker#1545 (review) . Let me know if you want me to take back over though; we really should get w3c/ServiceWorker#1545 merged.
source
Outdated
| @@ -2744,7 +2744,7 @@ a.setAttribute('href', 'https://example.com/'); // change the content attribute | |||
| <ul class="brief"> | |||
| <li><dfn data-x-href="https://tc39.es/ecma262/#active-function-object">active function object</dfn></li> | |||
| <li><dfn data-x-href="https://tc39.es/ecma262/#sec-agents">agent</dfn> and | |||
| <dfn data-x-href="https://tc39.es/ecma262/#sec-agent-clusters">agent cluster</dfn></li> | |||
| <dfn export data-x-href="https://tc39.es/ecma262/#sec-agent-clusters">agent cluster</dfn></li> | |||
There was a problem hiding this comment.
This should not be exported; instead you should reference the JavaScript spec directly.
|
Ping @annevk |
|
I need a status update. As far as I can tell w3c/ServiceWorker#1545 never merged. Is there something I missed? |
|
Sorry I don't remember why I closed the PR... Given https://github.com/w3c/ServiceWorker/pull/1545/files#r563704060, is it probably good to remake this PR for the definition of the operation referred in the comment? |
|
Yeah, if that's not too much trouble I'd appreciate it. It seems nice to contain that somehow in case we can ever properly define (or remove) it. |
yutakahirano
force-pushed
the
yhirano/export-cross-origin-isolation-mode
branch
from
0ff6aaf
to
40ecfd8
Compare
|
Updated. |
| @@ -2720,7 +2720,7 @@ a.setAttribute('href', 'https://example.com/'); // change the content attribute | |||
| <ul class="brief"> | |||
| <li><dfn data-x-href="https://tc39.es/ecma262/#active-function-object">active function object</dfn></li> | |||
| <li><dfn data-x-href="https://tc39.es/ecma262/#sec-agents">agent</dfn> and | |||
| <dfn data-x-href="https://tc39.es/ecma262/#sec-agent-clusters">agent cluster</dfn></li> | |||
| <dfn export data-x-href="https://tc39.es/ecma262/#sec-agent-clusters">agent cluster</dfn></li> | |||
There was a problem hiding this comment.
If service workers needs to talk about agent clusters it should also reference JavaScript directly.
source
Outdated
| <span>implementation-defined</span>.</p> | ||
| data-x="agent-cluster-cross-origin-isolation">cross-origin isolation mode</span> to the result | ||
| of <span data-x="choose a cross-origin isolation mode">choosing a cross-origin isolateion | ||
| mode</span> with <var>worker global scope</var>. | ||
|
|
||
| <p class="XXX">This really ought to be set when the agent cluster is created, which requires a | ||
| redesign of this section.</p> |
There was a problem hiding this comment.
Oh I see. Okay, I guess I have to take my suggestion back. As the real answer here is that this should be part of "obtain a worker/worklet agent" once this has been redone. I'm sorry. Would this just require reverting the second commit here? I'm happy to help.
yutakahirano
force-pushed
the
yhirano/export-cross-origin-isolation-mode
branch
from
40ecfd8
to
5539aeb
Compare
| @@ -2720,7 +2720,7 @@ a.setAttribute('href', 'https://example.com/'); // change the content attribute | |||
| <ul class="brief"> | |||
| <li><dfn data-x-href="https://tc39.es/ecma262/#active-function-object">active function object</dfn></li> | |||
| <li><dfn data-x-href="https://tc39.es/ecma262/#sec-agents">agent</dfn> and | |||
| <dfn data-x-href="https://tc39.es/ecma262/#sec-agent-clusters">agent cluster</dfn></li> | |||
| <dfn export data-x-href="https://tc39.es/ecma262/#sec-agent-clusters">agent cluster</dfn></li> | |||
| @@ -87210,7 +87213,7 @@ interface <dfn>BeforeUnloadEvent</dfn> : <span>Event</span> { | |||
|
|
|||
| <div w-nodev> | |||
|
|
|||
| <p>An <span>agent cluster</span> has an associated <dfn | |||
| <p>An <span>agent cluster</span> has an associated <dfn export | |||
There was a problem hiding this comment.
This needs for="agent cluster", right?
|
Ping @yutakahirano on resolving review comments. |
|
Sorry I lost the context. This was needed for w3c/ServiceWorker#1545 which I closed. We should probably close this, but it seems we still lack logic to set cross-origin isolated correctly for service workers. @ArthurSonzogni, is my understanding correct? Should I create another PR? |
I asked offline @yutakahirano how this question relates to me, and this was about:
Yes, I believe this is correct. I guess you want to export the 3 values for |
No behavior change.
/browsers.html ( diff )
/infrastructure.html ( diff )
/webappapis.html ( diff )