Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix browserhistory #3807

Closed
wants to merge 24 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
9af0d35
Fix for modal history push in ballot page
anup2307 Dec 19, 2023
aec350f
WV-175/updated OpenPlay privacy policy link
alc0ve Nov 28, 2023
468afa2
add max-heithg:200px to PoliticanImageDesktop
Nov 29, 2023
1cc2bdf
fix: package.json & package-lock.json to reduce vulnerabilities
snyk-bot Nov 30, 2023
2fac503
A snyk security upgrade moved forward the version of glob we are usin…
DaleMcGrew Dec 1, 2023
493569e
WV-136
sunnykarim Nov 17, 2023
ba36b3a
Improving engineering documentation.
DaleMcGrew Dec 3, 2023
1163008
Update package-lock.json
sunnykarim Dec 3, 2023
de4233a
Update package.json
sunnykarim Dec 3, 2023
b75fcc8
Update ShowMoreItems.jsx
sunnykarim Dec 3, 2023
52016dc
No tooltips in mobile or Cordova, for Jira issue 174
SailingSteve Dec 5, 2023
2acfe36
No tooltips in mobile or Cordova, for Jira issue 174
SailingSteve Dec 6, 2023
25acb0d
No tooltips in mobile or Cordova, for Jira issue 174
SailingSteve Dec 6, 2023
b5a32b2
No tooltips in mobile or Cordova, for Jira issue 174
SailingSteve Dec 7, 2023
9da61ec
add storybook with buttons
Dec 7, 2023
0e8f34b
add storybook components
Dec 8, 2023
300ed50
add accessebility for BaseButton
Dec 9, 2023
1e2662b
add accessebility for BaseButton
Dec 9, 2023
c921686
stash
Dec 9, 2023
513a682
add Chromatic into Storybook
Dec 11, 2023
3a3ca40
[WV-166] Fix (#3796)
cbarnes0 Dec 13, 2023
408ba28
Allow iOS "From Messages" value to auto fill SMS verification code (#…
SailingSteve Dec 13, 2023
d74d00f
Reduce vertical vibration on verify code dialog in cordova when adva…
SailingSteve Dec 18, 2023
02f847b
Add colors to the Storybook (#3806)
ivanko22 Dec 18, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,8 @@
"react/sort-comp": 1,
"space-before-function-paren": [1, {"anonymous": "always", "named": "always"}],
"space-in-parens": [1],
"template-curly-spacing": ["warn", "never"]
"template-curly-spacing": ["warn", "never"],
"react/jsx-filename-extension": [1, { "extensions": [".js", ".jsx"] }],
},
"plugins": [
"react",
Expand Down
22 changes: 22 additions & 0 deletions .storybook/main.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
/** @type { import('@storybook/react-webpack5').StorybookConfig } */
const config = {
stories: ["../src/**/*.mdx", "../src/**/*.stories.@(js|jsx|mjs|ts|tsx)"],
addons: [
"@storybook/addon-links",
"@storybook/addon-essentials",
"@storybook/addon-onboarding",
"@storybook/addon-interactions",
],
framework: {
name: "@storybook/react-webpack5",
options: {
builder: {
useSWC: true,
},
},
},
docs: {
autodocs: "tag",
},
};
export default config;
14 changes: 14 additions & 0 deletions .storybook/preview.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
/** @type { import('@storybook/react').Preview } */
const preview = {
parameters: {
actions: { argTypesRegex: "^on[A-Z].*" },
controls: {
matchers: {
color: /(background|color)$/i,
date: /Date$/i,
},
},
},
};

export default preview;
16 changes: 11 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,15 +33,21 @@ Automated Installation
## Working with WebApp
1. [Working with WebApp Day-to-Day](docs/working/README_WORKING_WITH_WEB_APP.md)

2. [Debugging Tools and Tips](docs/working/DEBUGGING_TOOLS.md)
2. [What the Heck is a Pull Request?](docs/contributing/PULL_REQUEST_BACKGROUND.md)

3. [Issues and Reporting Bugs](docs/working/ISSUES.md)
3. [Before Your First Pull Request](docs/contributing/PULL_REQUEST_SETUP.md)

4. [Styling Guidelines](docs/working/STYLING.md)
4. [Creating a Pull Request](docs/contributing/CREATING_PULL_REQUEST.md)

5. [Want to sign in with Facebook or Twitter on localhost?](docs/working/SECURE_CERTIFICATE.md)
5. [Debugging Tools and Tips](docs/working/DEBUGGING_TOOLS.md)

6. [Working with ngrok to test on mobile](docs/working/WORKING_WITH_NGROK.md)
6. [Issues and Reporting Bugs](docs/working/ISSUES.md)

7. [Styling Guidelines](docs/working/STYLING.md)

8. [Want to sign in with Facebook or Twitter on localhost?](docs/working/SECURE_CERTIFICATE.md)

9. [Working with ngrok to test on mobile](docs/working/WORKING_WITH_NGROK.md)

Thanks to BrowserStack for helping us with automated testing!

Expand Down
18 changes: 15 additions & 3 deletions docs/contributing/CONTRIBUTING_STANDARDS.md
Original file line number Diff line number Diff line change
Expand Up @@ -122,12 +122,24 @@ We value Software Craftsmanship for the We Vote project since it makes working o
* If you need to fix the open source projects we rely on, please make a pull request against that project.


# If there's no issue in github.com, please create one
# Reporting Bugs / Issues

## Let us Know you're working on the issue
## Reporting bugs as member of the engineering team

If you're actively working on an issue, please comment in the issue thread stating that you're working on a fix, or (if you're an official contributor) assign it to yourself. You can also keep the team updated on the work you are doing by attending a team stand-up held on the Daily Hangouts, or post a note in the #agile-stand-up Slack channel. This way, others will know they shouldn't try to work on a fix at the same time.
* We use Jira to track issues with the We Vote website and mobile Apps, thanks to [Atlassian, the makers of Jira](https://www.atlassian.com/software/views/open-source-license-request#/), and their support for open source projects.
* If you're actively working on an issue, please mark it as "Fix in Progress" and assign the issue to yourself.
* Please only "take" one issue at a time, unless you speak to the Engineering Manager first.
* Please keep the team updated on the work you are doing by attending our weekly stand-up meeting, or post a note in the #coding Slack channel.
* We encourage "Find it-Fix-it" for issues you find, if you are able.
* If you would like to report a bug for another engineer to fix, please report it in the #engineering-bug-reports Slack channel

## Reporting bugs if not part the engineering team

* Anyone can report issues [via our support system](https://help.wevote.us/hc/en-us/requests/new)
* Please provide a link to where you saw the issue
* Describe the issue with as much detail as you can -- details really help us reproduce the problem so we can find a fix
* ...and THANK YOU for taking the time to report the issue. We appreciate it!
* Want to join our team? We are 100% volunteer, and [volunteer opportunities are here](https://wevote.applytojob.com/apply/).

# Version numbering

Expand Down
Loading