-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix browserhistory #3807
Closed
Closed
Fix browserhistory #3807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-INFLIGHT-6095116
…g, which required a minor syntax change. Also fixed spacing errors caught by ESLINT. Added comment to PoliticianImageDesktop fix.
Resolves https://wevoteusa.atlassian.net/browse/WV-174 Removes sign in with Facebook from Cordova Android (temporary).
Resolves https://wevoteusa.atlassian.net/browse/WV-174 Removes sign in with Facebook from Cordova Android (temporary).
Resolves https://wevoteusa.atlassian.net/browse/WV-174 Removes sign in with Facebook from Cordova Android (temporary).
Resolves https://wevoteusa.atlassian.net/browse/WV-174 Removes sign in with Facebook from Cordova Android (temporary).
add storybook with buttons
* [WV-166] changes made in CampaignsHomeLoader.jsx and addressFunctions.js in order to load header/navbar when loading candidates page outside of the country. Instead of routing to -candidates/cs when out of the country will route to /cs * [WV-166] cleaning up commits etc.
…cing to new digit field (wevote#3804)
* add colors to storybook * change order of buttons on Storybook --------- Co-authored-by: Ivan Kordonets <[email protected]>
wrong changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github.com/wevote/WebApp/issues does this fix?
Related to WV-127 History push issue.
Changes included this pull request?
HistoryPush.js
ShareButtonDesktoptablet.jsx
ballot.jsx