Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8.4 to CI matrix #1639

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Add PHP 8.4 to CI matrix #1639

merged 1 commit into from
Nov 12, 2024

Conversation

simPod
Copy link
Collaborator

@simPod simPod commented Nov 12, 2024

No description provided.

@simPod simPod enabled auto-merge (squash) November 12, 2024 09:44
@simPod simPod merged commit 1e12e02 into webonyx:master Nov 12, 2024
29 checks passed
@simPod simPod mentioned this pull request Nov 12, 2024
@simPod simPod deleted the whatsup2 branch November 12, 2024 09:46
@ruudk
Copy link
Contributor

ruudk commented Nov 12, 2024

@simPod The auto format workflow is not ideal. Whenever it pushes a change, it doesn't trigger the workflows, because it's not a PAT. If the contributor wants their PR green again, they have to pull and rebase/force push, to get it green again.

@simPod
Copy link
Collaborator Author

simPod commented Nov 12, 2024

I did some work around that in the past

9dbc47a it should use PAT or user token.

also this #1506


so are you saying it is not working for MRs created from fork now?

@ruudk
Copy link
Contributor

ruudk commented Nov 12, 2024

Just had it on my latest PR. The checks all are orange and I have to pull and force push

@simPod
Copy link
Collaborator Author

simPod commented Nov 12, 2024

I see, something somewhere got broken

#1640

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants