Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8.4 to CI matrix #1637

Closed
wants to merge 2 commits into from
Closed

Add PHP 8.4 to CI matrix #1637

wants to merge 2 commits into from

Conversation

ruudk
Copy link
Contributor

@ruudk ruudk commented Nov 12, 2024

No description provided.

@spawnia spawnia enabled auto-merge (rebase) November 12, 2024 08:28
@spawnia
Copy link
Collaborator

spawnia commented Nov 12, 2024

@simPod This pull request seems to be blocked because the checks composer-normalize and php-cs-fixer are now required. I can not seem to bypass this, and it seems like I can not access the setting that would make them not required. Do you have permissions I do not have in the project, or am I looking in the wrong place?

@ruudk
Copy link
Contributor Author

ruudk commented Nov 12, 2024

If you have access to the settings, it could be that they use the new rulesets feature located in https://github.com/webonyx/graphql-php/settings/rules

@spawnia
Copy link
Collaborator

spawnia commented Nov 12, 2024

Yeah, I am getting a 404 for that page. Summoning @vladar, can you extend my permissions?

@simPod
Copy link
Collaborator

simPod commented Nov 12, 2024

It's here

https://github.com/webonyx/graphql-php/settings/branch_protection_rules/12748505

why are they not running 🤔

@simPod
Copy link
Collaborator

simPod commented Nov 12, 2024

I've removed those Required rules, try force pushing to trigger creation of new actions.

auto-merge was automatically disabled November 12, 2024 08:44

Head branch was pushed to by a user without write access

@ruudk
Copy link
Contributor Author

ruudk commented Nov 12, 2024

It should have pull_request too:

see

@ruudk
Copy link
Contributor Author

ruudk commented Nov 12, 2024

Fixed it :)

@ruudk
Copy link
Contributor Author

ruudk commented Nov 12, 2024

I guess this doesn't work. The way this auto format thing works, it doesn't want to run on the pull_request at all.

@ruudk
Copy link
Contributor Author

ruudk commented Nov 12, 2024

Removed it, those required checks need to be removed... or, the auto format thing needs to be revisited.

@simPod
Copy link
Collaborator

simPod commented Nov 12, 2024

merged in #1639

I've also cleanup all autoformats from required checks. Should be fine now.

@simPod simPod closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants