-
-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PHP 8.4 to CI matrix #1637
Add PHP 8.4 to CI matrix #1637
Conversation
@simPod This pull request seems to be blocked because the checks |
If you have access to the settings, it could be that they use the new rulesets feature located in https://github.com/webonyx/graphql-php/settings/rules |
Yeah, I am getting a 404 for that page. Summoning @vladar, can you extend my permissions? |
It's here https://github.com/webonyx/graphql-php/settings/branch_protection_rules/12748505 why are they not running 🤔 |
I've removed those Required rules, try force pushing to trigger creation of new actions. |
Head branch was pushed to by a user without write access
It should have pull_request too: graphql-php/.github/workflows/autoformat.yml Lines 3 to 4 in 0420ef7
see
|
Fixed it :) |
I guess this doesn't work. The way this auto format thing works, it doesn't want to run on the pull_request at all. |
Removed it, those required checks need to be removed... or, the auto format thing needs to be revisited. |
merged in #1639 I've also cleanup all autoformats from required checks. Should be fine now. |
No description provided.