Remove karma dependencies - no longer maintained #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeijer
force-pushed
the
karma-deprecation-mocha-bump
branch
from
94855b8
to
0c19c70
Compare
pmeijer
commented
Jun 20, 2024
| if (userId === entityId) { | ||
| return readWrite; | ||
| } | ||
|
|
There was a problem hiding this comment.
Messed this up on the last PR.
pmeijer
commented
Jun 20, 2024
| @@ -1918,7 +1933,12 @@ describe('SafeStorage', function () { | |||
| throw new Error('Should have failed!'); | |||
| }) | |||
| .catch(function (err) { | |||
| expect(err.message).to.contain('Invalid argument, data.projectName failed regexp: '); | |||
| try { | |||
| expect(err.message).to.contain('Invalid argument, data.projectName failed regexp: '); | |||
There was a problem hiding this comment.
Was adding these to track down why the tests just failed with no error.. Reformatted the file when saving and then it started to complain about indent..
I broke up the var statements to fix those and while I did that I added const instead of var.. Down the rabbit-hole in other words.
kecso
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.