Merge pull request #15 from weaviate/remove_hardcoded_debug_level

Remove hardcoded LOG_LEVEL.
weaviate · Oct 10, 2024 · 0ba87f1 · 0ba87f1
2 parents 0a579d9 + 1c9322d
commit 0ba87f1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -62,6 +62,7 @@ jobs:
             size: 50Gi
           env:
             ASYNC_INDEXING: true
+            LOG_LEVEL: debug
         VALUES_INLINE: '--set env.PERSISTENCE_LSM_ACCESS_STRATEGY=pread'
       steps:
         - name: Checkout repository
@@ -119,6 +120,11 @@ jobs:
                   echo "Error: env.ASYNC_INDEXING is not equal to true. Found $env_value"
                   exit 1
               fi
+              env_value=$(kubectl get sts weaviate -n weaviate -o=jsonpath='{.spec.template.spec.containers[0].env[?(@.name=="LOG_LEVEL")].value}')
+              if [[ "$env_value" != "debug" ]]; then
+                  echo "Error: env.LOG_LEVEL is not equal to debug. Found $env_value"
+                  exit 1
+              fi
               env_value=$(kubectl get sts weaviate -n weaviate -o=jsonpath='{.spec.template.spec.containers[0].env[?(@.name=="PERSISTENCE_LSM_ACCESS_STRATEGY")].value}')
               if [[ "$env_value" != "pread" ]]; then
                   echo "Error: env.PERSISTENCE_LSM_ACCESS_STRATEGY is not equal to pread. Found $env_value"

diff --git a/utilities/helpers.sh b/utilities/helpers.sh
@@ -209,7 +209,6 @@ function generate_helm_values() {
                         --set replicas=$REPLICAS \
                         --set grpcService.enabled=true \
                         --set env.RAFT_BOOTSTRAP_TIMEOUT=3600 \
-                        --set env.LOG_LEVEL=info \
                         --set env.DISABLE_RECOVERY_ON_PANIC=true \
                         --set env.PROMETHEUS_MONITORING_ENABLED=true \
                         --set env.DISABLE_TELEMETRY=true"