Skip to content

Commit

Permalink
Remove hardcoded LOG_LEVEL.
Browse files Browse the repository at this point in the history
The LOG_LEVEL by default is already INFO, no need to override.
  • Loading branch information
jfrancoa committed Oct 10, 2024
1 parent 0a579d9 commit 1c9322d
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
6 changes: 6 additions & 0 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ jobs:
size: 50Gi
env:
ASYNC_INDEXING: true
LOG_LEVEL: debug
VALUES_INLINE: '--set env.PERSISTENCE_LSM_ACCESS_STRATEGY=pread'
steps:
- name: Checkout repository
Expand Down Expand Up @@ -119,6 +120,11 @@ jobs:
echo "Error: env.ASYNC_INDEXING is not equal to true. Found $env_value"
exit 1
fi
env_value=$(kubectl get sts weaviate -n weaviate -o=jsonpath='{.spec.template.spec.containers[0].env[?(@.name=="LOG_LEVEL")].value}')
if [[ "$env_value" != "debug" ]]; then
echo "Error: env.LOG_LEVEL is not equal to debug. Found $env_value"
exit 1
fi
env_value=$(kubectl get sts weaviate -n weaviate -o=jsonpath='{.spec.template.spec.containers[0].env[?(@.name=="PERSISTENCE_LSM_ACCESS_STRATEGY")].value}')
if [[ "$env_value" != "pread" ]]; then
echo "Error: env.PERSISTENCE_LSM_ACCESS_STRATEGY is not equal to pread. Found $env_value"
Expand Down
1 change: 0 additions & 1 deletion utilities/helpers.sh
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,6 @@ function generate_helm_values() {
--set replicas=$REPLICAS \
--set grpcService.enabled=true \
--set env.RAFT_BOOTSTRAP_TIMEOUT=3600 \
--set env.LOG_LEVEL=info \
--set env.DISABLE_RECOVERY_ON_PANIC=true \
--set env.PROMETHEUS_MONITORING_ENABLED=true \
--set env.DISABLE_TELEMETRY=true"
Expand Down

0 comments on commit 1c9322d

Please sign in to comment.